public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] OMAP3: twister: add video support
Date: Thu, 21 Jun 2012 09:21:59 +0200	[thread overview]
Message-ID: <4FE2CB97.7060901@denx.de> (raw)
In-Reply-To: <20120621011553.GB27000@bill-the-cat>

On 21/06/2012 03:15, Tom Rini wrote:
> On Thu, Jun 14, 2012 at 10:29:47AM +0200, Stefano Babic wrote:
> 

Hi Tom,

>> Signed-off-by: Stefano Babic <sbabic@denx.de>
> [snip]
>> +static GraphicDevice panel;
>> +static const struct panel_config lcd_cfg = {
>> +	.timing_h	= 0x01101d1b, /* Horizontal timing */
>> +	.timing_v	= 0x01400b02, /* Vertical timing */
>> +	.pol_freq	= 0x00023000, /* Pol Freq */
>> +	.divisor	= 0x0001000d, /* 33Mhz Pixel Clock */
>> +	.lcd_size	= ((YRES - 1) << 16 | (XRES - 1)),
>> +	.panel_type	= 0x01, /* TFT */
>> +	.data_lines	= 0x03, /* 24 Bit RGB */
>> +	.load_mode	= 0x02 /* Frame Mode */
>> +};
> 
> You need #if defined(CONFIG_VIDEO) && !defined(CONFIG_SPL_BUILD)
> type testing here[1] that the mt_ventoux board patch has.  Shall I or
> will you v2?  And I'll sanity test this on omap3_beagle tomorrow, but I
> suspect it's fine :)

I discussed with Anatolji about the patches and they need to be rebased
and reworked - a v2 is necessary !

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2012-06-21  7:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14  8:29 [U-Boot] [PATCH 1/4] video: omap3_dss: add setup for LCD Stefano Babic
2012-06-14  8:29 ` [U-Boot] [PATCH 2/4] OMAP3: added clock definitions for OMAP3 DSS driver Stefano Babic
2012-06-14  8:29 ` [U-Boot] [PATCH 3/4] OMAP3: twister: add video support Stefano Babic
2012-06-21  1:15   ` Tom Rini
2012-06-21  7:21     ` Stefano Babic [this message]
2012-06-14  8:29 ` [U-Boot] [PATCH 4/4] OMAP3: mt_ventoux: add video/ splashscreen support Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE2CB97.7060901@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox