* [U-Boot] [PATCH] mx53loco: use print_cpuinfo() defined in imx-common
@ 2012-06-23 2:21 Ashok
2012-06-23 15:35 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Ashok @ 2012-06-23 2:21 UTC (permalink / raw)
To: u-boot
use print_cpuinfo() defined in imx-common/cpu.c,
instead of duplicating function.
Signed-off-by: Ashok Kumar Reddy kourla <ashokkourla2000@gmail.com>
---
board/freescale/mx53loco/mx53loco.c | 14 --------------
include/configs/mx53loco.h | 1 +
2 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/board/freescale/mx53loco/mx53loco.c
b/board/freescale/mx53loco/mx53loco.c
index d8e027c..cc57bb3 100644
--- a/board/freescale/mx53loco/mx53loco.c
+++ b/board/freescale/mx53loco/mx53loco.c
@@ -478,20 +478,6 @@ int board_early_init_f(void)
return 0;
}
-int print_cpuinfo(void)
-{
- u32 cpurev;
-
- cpurev = get_cpu_rev();
- printf("CPU: Freescale i.MX%x family rev%d.%d at %d MHz\n",
- (cpurev & 0xFF000) >> 12,
- (cpurev & 0x000F0) >> 4,
- (cpurev & 0x0000F) >> 0,
- mxc_get_clock(MXC_ARM_CLK) / 1000000);
- printf("Reset cause: %s\n", get_reset_cause());
- return 0;
-}
-
#ifdef CONFIG_BOARD_LATE_INIT
int board_late_init(void)
{
diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
index 8b4e008..29fa6b4 100644
--- a/include/configs/mx53loco.h
+++ b/include/configs/mx53loco.h
@@ -28,6 +28,7 @@
#define CONFIG_SYS_MX5_HCLK 24000000
#define CONFIG_SYS_MX5_CLK32 32768
#define CONFIG_DISPLAY_BOARDINFO
+#define CONFIG_DISPLAY_CPUINFO
#define CONFIG_MACH_TYPE MACH_TYPE_MX53_LOCO
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mx53loco: use print_cpuinfo() defined in imx-common
2012-06-23 2:21 [U-Boot] [PATCH] mx53loco: use print_cpuinfo() defined in imx-common Ashok
@ 2012-06-23 15:35 ` Fabio Estevam
2012-06-23 18:13 ` Ashok
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2012-06-23 15:35 UTC (permalink / raw)
To: u-boot
Hi Ashok,
On Fri, Jun 22, 2012 at 11:21 PM, Ashok <ashokkourla2000@gmail.com> wrote:
> use print_cpuinfo() defined in imx-common/cpu.c,
> instead of duplicating function.
The reason for duplicating this function is that we cannot print the
CPU info right in the beginning, because if we do so the frequency of
800MHz would be reported, instead of the 1GHz that is only set later
via I2C commands to the PMIC.
So, please let the code as is to avoid wrong CPU frequency to be reported.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mx53loco: use print_cpuinfo() defined in imx-common
2012-06-23 15:35 ` Fabio Estevam
@ 2012-06-23 18:13 ` Ashok
0 siblings, 0 replies; 3+ messages in thread
From: Ashok @ 2012-06-23 18:13 UTC (permalink / raw)
To: u-boot
On 23-06-2012 21:05, Fabio Estevam wrote:
> Hi Ashok,
>
> On Fri, Jun 22, 2012 at 11:21 PM, Ashok <ashokkourla2000@gmail.com> wrote:
>> use print_cpuinfo() defined in imx-common/cpu.c,
>> instead of duplicating function.
>
> The reason for duplicating this function is that we cannot print the
> CPU info right in the beginning, because if we do so the frequency of
> 800MHz would be reported, instead of the 1GHz that is only set later
> via I2C commands to the PMIC.
>
> So, please let the code as is to avoid wrong CPU frequency to be reported.
>
> Regards,
>
> Fabio Estevam
>
Hi Fabio,
Thanks for the information.
Regards,
Ashok
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-23 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-23 2:21 [U-Boot] [PATCH] mx53loco: use print_cpuinfo() defined in imx-common Ashok
2012-06-23 15:35 ` Fabio Estevam
2012-06-23 18:13 ` Ashok
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox