From: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0
Date: Mon, 25 Jun 2012 21:42:29 +0900 [thread overview]
Message-ID: <4FE85CB5.6070505@kmckk.co.jp> (raw)
save_boot_params_default() in cpu.c accesses uninitialized stack area
when it compiled with -O0 (not optimized).
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
arch/arm/cpu/armv7/cpu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/cpu/armv7/cpu.c b/arch/arm/cpu/armv7/cpu.c
index c6fa8ef..6104cb2 100644
--- a/arch/arm/cpu/armv7/cpu.c
+++ b/arch/arm/cpu/armv7/cpu.c
@@ -37,8 +37,11 @@
#include <asm/cache.h>
#include <asm/armv7.h>
+__attribute__((naked)) /* don't save anything to stack even if compiled with -O0 */
void save_boot_params_default(u32 r0, u32 r1, u32 r2, u32 r3)
{
+ /* stack is not yet initialized */
+ asm("bx lr");
}
void save_boot_params(u32 r0, u32 r1, u32 r2, u32 r3)
--
1.7.9.5
next reply other threads:[~2012-06-25 12:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 12:42 Tetsuyuki Kobayashi [this message]
2012-06-27 17:40 ` [U-Boot] [PATCH] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0 Tom Rini
2012-06-28 1:14 ` Tetsuyuki Kobayashi
2012-06-28 11:35 ` [U-Boot] [PATCH v2] " Tetsuyuki Kobayashi
2012-06-28 14:57 ` Tom Rini
2012-06-28 16:00 ` koba
2012-06-29 9:36 ` [U-Boot] [PATCH v3] " Tetsuyuki Kobayashi
2012-06-29 14:21 ` Tom Rini
2012-07-05 9:25 ` Albert ARIBAUD
2012-07-05 11:57 ` Albert ARIBAUD
2012-07-05 16:18 ` Tom Rini
2012-07-05 17:10 ` Albert ARIBAUD
2012-07-06 6:10 ` [U-Boot] [PATCH v4] " Tetsuyuki Kobayashi
2012-07-06 14:00 ` Tom Rini
2012-07-07 7:14 ` [U-Boot] [PATCH v5] " Tetsuyuki Kobayashi
2012-07-09 8:55 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE85CB5.6070505@kmckk.co.jp \
--to=koba@kmckk.co.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox