From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] rbpi: Add BCM2835 GPIO driver for raspberry pi
Date: Tue, 26 Jun 2012 19:40:59 -0600 [thread overview]
Message-ID: <4FEA64AB.7040106@wwwdotorg.org> (raw)
In-Reply-To: <4FE74CCA.2070600@gmail.com>
On 06/24/2012 11:22 AM, Vikram Narayanan wrote:
>
> Add the driver to the rpi_b's default config
It looks like there's a blank line before the patch description there.
Aside from that and the nit below,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> diff --git a/include/configs/rpi_b.h b/include/configs/rpi_b.h
> /* Devices */
> -/* None yet */
> +/* GPIO */
> +#define CONFIG_BCM2835_GPIO
> +
>
No need to add an extra blank line there.
next prev parent reply other threads:[~2012-06-27 1:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 17:19 [U-Boot] [PATCH 0/2] Add GPIO driver for BCM2835 SoC Vikram Narayanan
2012-06-24 17:21 ` [U-Boot] [PATCH 1/2] bcm: " Vikram Narayanan
2012-06-27 1:39 ` Stephen Warren
2012-06-27 17:32 ` Vikram Narayanan
2012-06-27 18:06 ` Stephen Warren
2012-06-28 2:59 ` Vikram Narayanan
2012-06-28 17:42 ` Stephen Warren
2012-06-24 17:22 ` [U-Boot] [PATCH 2/2] rbpi: Add BCM2835 GPIO driver for raspberry pi Vikram Narayanan
2012-06-27 1:40 ` Stephen Warren [this message]
2012-07-04 2:07 ` [U-Boot] [PATCH 0/2] Add GPIO driver for BCM2835 SoC Stephen Warren
2012-07-04 3:22 ` Vikram Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEA64AB.7040106@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox