From: Vikram Narayanan <vikram186@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] bcm: Add GPIO driver for BCM2835 SoC
Date: Wed, 27 Jun 2012 23:02:18 +0530 [thread overview]
Message-ID: <4FEB43A2.2020700@gmail.com> (raw)
In-Reply-To: <4FEA645E.6070806@wwwdotorg.org>
Hello Stephen,
On 6/27/2012 7:09 AM, Stephen Warren wrote:
> On 06/24/2012 11:21 AM, Vikram Narayanan wrote:
>
> First off, it's great to see some patches for the chip. Thanks. Sorry
> for being so nit-picky below; it's a tendency of mine...
Thanks for the detailed review. I'd make a v2 for this.
And I might probably include you in the signed-off-by line.
Hope you don't mind that.
Do you have a hosted repo somewhere for this rpi_b stuff?
If so, please post it here or we shall have one, which has all the
patches queued in for the mainline. What do you say? Share your opinions
about this.
> BTW, I don't think this patch compiles; gpio_set_value() references
> variable "pin", which doesn't exist.
Sorry about that, Late night submission!
Thanks,
Vikram
next prev parent reply other threads:[~2012-06-27 17:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 17:19 [U-Boot] [PATCH 0/2] Add GPIO driver for BCM2835 SoC Vikram Narayanan
2012-06-24 17:21 ` [U-Boot] [PATCH 1/2] bcm: " Vikram Narayanan
2012-06-27 1:39 ` Stephen Warren
2012-06-27 17:32 ` Vikram Narayanan [this message]
2012-06-27 18:06 ` Stephen Warren
2012-06-28 2:59 ` Vikram Narayanan
2012-06-28 17:42 ` Stephen Warren
2012-06-24 17:22 ` [U-Boot] [PATCH 2/2] rbpi: Add BCM2835 GPIO driver for raspberry pi Vikram Narayanan
2012-06-27 1:40 ` Stephen Warren
2012-07-04 2:07 ` [U-Boot] [PATCH 0/2] Add GPIO driver for BCM2835 SoC Stephen Warren
2012-07-04 3:22 ` Vikram Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEB43A2.2020700@gmail.com \
--to=vikram186@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox