From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vikram Narayanan <vikram186@gmail.com>
Date: Wed, 27 Jun 2012 23:02:18 +0530
Subject: [U-Boot] [PATCH 1/2] bcm: Add GPIO driver for BCM2835 SoC
In-Reply-To: <4FEA645E.6070806@wwwdotorg.org>
References: <4FE74C1C.7080409@gmail.com> <4FE74C8E.2070306@gmail.com>
	<4FEA645E.6070806@wwwdotorg.org>
Message-ID: <4FEB43A2.2020700@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Stephen,

On 6/27/2012 7:09 AM, Stephen Warren wrote:
> On 06/24/2012 11:21 AM, Vikram Narayanan wrote:
>
> First off, it's great to see some patches for the chip. Thanks. Sorry
> for being so nit-picky below; it's a tendency of mine...

Thanks for the detailed review. I'd make a v2 for this.
And I might probably include you in the signed-off-by line.
Hope you don't mind that.

Do you have a hosted repo somewhere for this rpi_b stuff?
If so, please post it here or we shall have one, which has all the 
patches queued in for the mainline. What do you say? Share your opinions 
about this.

> BTW, I don't think this patch compiles; gpio_set_value() references
> variable "pin", which doesn't exist.

Sorry about that, Late night submission!

Thanks,
Vikram