* [U-Boot] [PATCH v2] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0
@ 2012-06-28 11:17 Tetsuyuki Kobayashi
2012-06-28 11:39 ` Tetsuyuki Kobayashi
0 siblings, 1 reply; 5+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-06-28 11:17 UTC (permalink / raw)
To: u-boot
save_boot_params_default() in cpu.c accesses uninitialized stack area
when it compiled with -O0 (not optimized).
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Changes for v2:
- include <linux/compiler.h> and use __naked instead of __attribute__((naked))
arch/arm/cpu/armv7/cpu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/cpu/armv7/cpu.c b/arch/arm/cpu/armv7/cpu.c
index c6fa8ef..3e2a75c 100644
--- a/arch/arm/cpu/armv7/cpu.c
+++ b/arch/arm/cpu/armv7/cpu.c
@@ -36,9 +36,13 @@
#include <asm/system.h>
#include <asm/cache.h>
#include <asm/armv7.h>
+#include <linux/compiler.h>
+__naked /* don't save anything to stack even if compiled with -O0 */
void save_boot_params_default(u32 r0, u32 r1, u32 r2, u32 r3)
{
+ /* stack is not yet initialized */
+ asm("bx lr");
}
void save_boot_params(u32 r0, u32 r1, u32 r2, u32 r3)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0
2012-06-28 1:14 ` Tetsuyuki Kobayashi
@ 2012-06-28 11:35 ` Tetsuyuki Kobayashi
2012-06-28 14:57 ` Tom Rini
0 siblings, 1 reply; 5+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-06-28 11:35 UTC (permalink / raw)
To: u-boot
save_boot_params_default() in cpu.c accesses uninitialized stack area
when it compiled with -O0 (not optimized).
Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
---
Changes for v2:
- include <linux/compiler.h> and use __naked instead of __attribute__((naked))
arch/arm/cpu/armv7/cpu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/cpu/armv7/cpu.c b/arch/arm/cpu/armv7/cpu.c
index c6fa8ef..3e2a75c 100644
--- a/arch/arm/cpu/armv7/cpu.c
+++ b/arch/arm/cpu/armv7/cpu.c
@@ -36,9 +36,13 @@
#include <asm/system.h>
#include <asm/cache.h>
#include <asm/armv7.h>
+#include <linux/compiler.h>
+__naked /* don't save anything to stack even if compiled with -O0 */
void save_boot_params_default(u32 r0, u32 r1, u32 r2, u32 r3)
{
+ /* stack is not yet initialized */
+ asm("bx lr");
}
void save_boot_params(u32 r0, u32 r1, u32 r2, u32 r3)
-- 1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0
2012-06-28 11:17 [U-Boot] [PATCH v2] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0 Tetsuyuki Kobayashi
@ 2012-06-28 11:39 ` Tetsuyuki Kobayashi
0 siblings, 0 replies; 5+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-06-28 11:39 UTC (permalink / raw)
To: u-boot
I'm sorry. This post is missing In-Reply-To. I sent again. Discard this.
(2012/06/28 20:17), Tetsuyuki Kobayashi wrote:
> save_boot_params_default() in cpu.c accesses uninitialized stack area
> when it compiled with -O0 (not optimized).
>
> Signed-off-by: Tetsuyuki Kobayashi<koba@kmckk.co.jp>
> ---
> Changes for v2:
> - include<linux/compiler.h> and use __naked instead of __attribute__((naked))
>
>
> arch/arm/cpu/armv7/cpu.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/cpu/armv7/cpu.c b/arch/arm/cpu/armv7/cpu.c
> index c6fa8ef..3e2a75c 100644
> --- a/arch/arm/cpu/armv7/cpu.c
> +++ b/arch/arm/cpu/armv7/cpu.c
> @@ -36,9 +36,13 @@
> #include<asm/system.h>
> #include<asm/cache.h>
> #include<asm/armv7.h>
> +#include<linux/compiler.h>
>
> +__naked /* don't save anything to stack even if compiled with -O0 */
> void save_boot_params_default(u32 r0, u32 r1, u32 r2, u32 r3)
> {
> + /* stack is not yet initialized */
> + asm("bx lr");
> }
>
> void save_boot_params(u32 r0, u32 r1, u32 r2, u32 r3)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0
2012-06-28 11:35 ` [U-Boot] [PATCH v2] " Tetsuyuki Kobayashi
@ 2012-06-28 14:57 ` Tom Rini
2012-06-28 16:00 ` koba
0 siblings, 1 reply; 5+ messages in thread
From: Tom Rini @ 2012-06-28 14:57 UTC (permalink / raw)
To: u-boot
On 06/28/2012 04:35 AM, Tetsuyuki Kobayashi wrote:
> save_boot_params_default() in cpu.c accesses uninitialized stack area
> when it compiled with -O0 (not optimized).
>
> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
> ---
> Changes for v2:
> - include <linux/compiler.h> and use __naked instead of __attribute__((naked))
>
>
> arch/arm/cpu/armv7/cpu.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/cpu/armv7/cpu.c b/arch/arm/cpu/armv7/cpu.c
> index c6fa8ef..3e2a75c 100644
> --- a/arch/arm/cpu/armv7/cpu.c
> +++ b/arch/arm/cpu/armv7/cpu.c
> @@ -36,9 +36,13 @@
> #include <asm/system.h>
> #include <asm/cache.h>
> #include <asm/armv7.h>
> +#include <linux/compiler.h>
>
> +__naked /* don't save anything to stack even if compiled with -O0 */
> void save_boot_params_default(u32 r0, u32 r1, u32 r2, u32 r3)
The usual form (here and kernel) is:
void __naked save_boot_params_default(...)
Same for __weak and so on. Thanks!
--
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH v2] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0
2012-06-28 14:57 ` Tom Rini
@ 2012-06-28 16:00 ` koba
0 siblings, 0 replies; 5+ messages in thread
From: koba @ 2012-06-28 16:00 UTC (permalink / raw)
To: u-boot
On 2012/06/28, at 23:57, Tom Rini wrote:
> On 06/28/2012 04:35 AM, Tetsuyuki Kobayashi wrote:
>> save_boot_params_default() in cpu.c accesses uninitialized stack area
>> when it compiled with -O0 (not optimized).
>>
>> Signed-off-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>> ---
>> Changes for v2:
>> - include <linux/compiler.h> and use __naked instead of __attribute__((naked))
>>
>>
>> arch/arm/cpu/armv7/cpu.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/cpu/armv7/cpu.c b/arch/arm/cpu/armv7/cpu.c
>> index c6fa8ef..3e2a75c 100644
>> --- a/arch/arm/cpu/armv7/cpu.c
>> +++ b/arch/arm/cpu/armv7/cpu.c
>> @@ -36,9 +36,13 @@
>> #include <asm/system.h>
>> #include <asm/cache.h>
>> #include <asm/armv7.h>
>> +#include <linux/compiler.h>
>>
>> +__naked /* don't save anything to stack even if compiled with -O0 */
>> void save_boot_params_default(u32 r0, u32 r1, u32 r2, u32 r3)
>
> The usual form (here and kernel) is:
> void __naked save_boot_params_default(...)
>
> Same for __weak and so on. Thanks!
>
Oh, I should grep __naked before posting this.
I will try V3.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-06-28 16:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-28 11:17 [U-Boot] [PATCH v2] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0 Tetsuyuki Kobayashi
2012-06-28 11:39 ` Tetsuyuki Kobayashi
-- strict thread matches above, loose matches on Subject: below --
2012-06-25 12:42 [U-Boot] [PATCH] " Tetsuyuki Kobayashi
2012-06-27 17:40 ` Tom Rini
2012-06-28 1:14 ` Tetsuyuki Kobayashi
2012-06-28 11:35 ` [U-Boot] [PATCH v2] " Tetsuyuki Kobayashi
2012-06-28 14:57 ` Tom Rini
2012-06-28 16:00 ` koba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox