* [U-Boot] [PATCH] video: fixed exynos_mipi_dsi_init() declaration
@ 2012-07-02 11:18 Donghwa Lee
2012-07-04 3:29 ` Minkyu Kang
0 siblings, 1 reply; 3+ messages in thread
From: Donghwa Lee @ 2012-07-02 11:18 UTC (permalink / raw)
To: u-boot
To avoid compilers error in case of not using
CONFIG_EXYNOS_MIPI_DSIM, add no operation function.
Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
index 9a7cbeb..b73263d 100644
--- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h
+++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
@@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver {
void (*mipi_display_on)(struct mipi_dsim_device *dsim_dev);
};
+#ifdef CONFIG_EXYNOS_MIPI_DSIM
int exynos_mipi_dsi_init(void);
+#else
+int exynos_mipi_dsi_init(void)
+{
+ return 0;
+}
+#endif
/*
* register mipi_dsim_lcd_driver object defined by lcd panel driver
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] video: fixed exynos_mipi_dsi_init() declaration
2012-07-02 11:18 [U-Boot] [PATCH] video: fixed exynos_mipi_dsi_init() declaration Donghwa Lee
@ 2012-07-04 3:29 ` Minkyu Kang
2012-07-04 4:26 ` Donghwa Lee
0 siblings, 1 reply; 3+ messages in thread
From: Minkyu Kang @ 2012-07-04 3:29 UTC (permalink / raw)
To: u-boot
On 2 July 2012 20:18, Donghwa Lee <dh09.lee@samsung.com> wrote:
> To avoid compilers error in case of not using
> CONFIG_EXYNOS_MIPI_DSIM, add no operation function.
>
> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
> index 9a7cbeb..b73263d 100644
> --- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h
> +++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
> @@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver {
> void (*mipi_display_on)(struct mipi_dsim_device *dsim_dev);
> };
>
> +#ifdef CONFIG_EXYNOS_MIPI_DSIM
> int exynos_mipi_dsi_init(void);
> +#else
> +int exynos_mipi_dsi_init(void)
> +{
> + return 0;
> +}
> +#endif
How about weak function instead of ifdef?
Thanks.
Minkyu Kang.
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] video: fixed exynos_mipi_dsi_init() declaration
2012-07-04 3:29 ` Minkyu Kang
@ 2012-07-04 4:26 ` Donghwa Lee
0 siblings, 0 replies; 3+ messages in thread
From: Donghwa Lee @ 2012-07-04 4:26 UTC (permalink / raw)
To: u-boot
On 4 July 2012 12:29, Minkyu Kang wrote:
> On 2 July 2012 20:18, Donghwa Lee <dh09.lee@samsung.com> wrote:
>> To avoid compilers error in case of not using
>> CONFIG_EXYNOS_MIPI_DSIM, add no operation function.
>>
>> Signed-off-by: Donghwa Lee <dh09.lee@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 +++++++
>> 1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
>> index 9a7cbeb..b73263d 100644
>> --- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h
>> +++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h
>> @@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver {
>> void (*mipi_display_on)(struct mipi_dsim_device *dsim_dev);
>> };
>>
>> +#ifdef CONFIG_EXYNOS_MIPI_DSIM
>> int exynos_mipi_dsi_init(void);
>> +#else
>> +int exynos_mipi_dsi_init(void)
>> +{
>> + return 0;
>> +}
>> +#endif
>
> How about weak function instead of ifdef?
>
> Thanks.
> Minkyu Kang.
Ok, It looks like better. I will fix it later.
Thank you,
Donghwa Lee.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-04 4:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-02 11:18 [U-Boot] [PATCH] video: fixed exynos_mipi_dsi_init() declaration Donghwa Lee
2012-07-04 3:29 ` Minkyu Kang
2012-07-04 4:26 ` Donghwa Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox