public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ext2fs: fix warning: 'blocknxt' may be used uninitialized
Date: Wed, 04 Jul 2012 00:12:12 +0200	[thread overview]
Message-ID: <4FF36E3C.4000808@googlemail.com> (raw)
In-Reply-To: <20120703110542.c8b827398ebcedf3448725e1@freescale.com>

Dear Kim Philips,

On 03.07.12 18:05, Kim Phillips wrote:
> ext2fs.c: In function 'ext2fs_read_file':
> ext2fs.c:458:19: warning: 'blocknxt' may be used uninitialized in this function [-Wuninitialized]
> 
> Cc: Jason Cooper <u-boot@lakedaemon.net>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> ---
> is this right?
> 
>  fs/ext2/ext2fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext2/ext2fs.c b/fs/ext2/ext2fs.c
> index f1fce48..c6c950e 100644
> --- a/fs/ext2/ext2fs.c
> +++ b/fs/ext2/ext2fs.c
> @@ -440,7 +440,7 @@ int ext2fs_read_file
>  		/* grab middle blocks in one go */
>  		if (i != pos / blocksize && i != blockcnt - 1 && blockcnt > 3) {
>  			int oldblk = blknr;
> -			int blocknxt;
> +			int blocknxt = 0;
>  			while (i < blockcnt - 1) {
>  				blocknxt = ext2fs_read_block(node, i + 1);
>  				if (blocknxt == (oldblk + 1)) {
> 

there are two other solutions. I dunno which should we use but Thierry
Reding suggested another working one which I think its cleaner. Please
read http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/134043

Best regards

Andreas Bie?mann

  reply	other threads:[~2012-07-03 22:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-28 14:37 [U-Boot] [PATCH] ext2load: increase read speed Jason Cooper
2012-04-26  1:17 ` Eric Nelson
2012-05-08 15:43   ` Jason Cooper
2012-05-08 15:53     ` Eric Nelson
2012-04-26 12:54 ` Thierry Reding
2012-05-08 15:48   ` Jason Cooper
2012-05-08 16:13 ` [U-Boot] [GIT PULL] ext2load speedup Jason Cooper
2012-05-21  1:35   ` [U-Boot] [GIT PULL RESEND] " Jason Cooper
2012-05-21  5:19     ` Wolfgang Denk
2012-06-01 15:41     ` Jason Cooper
2012-06-01 15:54 ` [U-Boot] [PATCH v2] ext2load: increase read speed Jason Cooper
2012-06-21 20:49   ` Wolfgang Denk
2012-07-03 16:05     ` [U-Boot] [PATCH] ext2fs: fix warning: 'blocknxt' may be used uninitialized Kim Phillips
2012-07-03 22:12       ` Andreas Bießmann [this message]
2012-07-03 22:41         ` [U-Boot] [PATCH v2] " Kim Phillips
2012-07-04  6:09           ` Thierry Reding
2012-07-06 13:31           ` Jason Cooper
2012-07-08 20:55           ` Wolfgang Denk
2012-07-23 18:56             ` Tom Rini
2012-07-24  4:59               ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF36E3C.4000808@googlemail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox