From mboxrd@z Thu Jan 1 00:00:00 1970 From: Donghwa Lee Date: Wed, 04 Jul 2012 13:26:27 +0900 Subject: [U-Boot] [PATCH] video: fixed exynos_mipi_dsi_init() declaration In-Reply-To: References: <4FF18398.8070200@samsung.com> Message-ID: <4FF3C5F3.1050700@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 4 July 2012 12:29, Minkyu Kang wrote: > On 2 July 2012 20:18, Donghwa Lee wrote: >> To avoid compilers error in case of not using >> CONFIG_EXYNOS_MIPI_DSIM, add no operation function. >> >> Signed-off-by: Donghwa Lee >> Signed-off-by: Kyungmin Park >> --- >> arch/arm/include/asm/arch-exynos/mipi_dsim.h | 7 +++++++ >> 1 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/include/asm/arch-exynos/mipi_dsim.h b/arch/arm/include/asm/arch-exynos/mipi_dsim.h >> index 9a7cbeb..b73263d 100644 >> --- a/arch/arm/include/asm/arch-exynos/mipi_dsim.h >> +++ b/arch/arm/include/asm/arch-exynos/mipi_dsim.h >> @@ -358,7 +358,14 @@ struct mipi_dsim_lcd_driver { >> void (*mipi_display_on)(struct mipi_dsim_device *dsim_dev); >> }; >> >> +#ifdef CONFIG_EXYNOS_MIPI_DSIM >> int exynos_mipi_dsi_init(void); >> +#else >> +int exynos_mipi_dsi_init(void) >> +{ >> + return 0; >> +} >> +#endif > > How about weak function instead of ifdef? > > Thanks. > Minkyu Kang. Ok, It looks like better. I will fix it later. Thank you, Donghwa Lee.