* [U-Boot] [PATCH] cm-t35: fix incorrect NAND_ECC layout selection
@ 2012-07-02 12:27 Nikita Kiryanov
2012-07-02 16:06 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Nikita Kiryanov @ 2012-07-02 12:27 UTC (permalink / raw)
To: u-boot
The current configuration selects an incorrect NAND ECC layout,
which causes u-boot to write HW ECC data incorrectly.
This patch selects the right layout.
Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
---
include/configs/cm_t35.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h
index 1419f06..e0dd3fb 100644
--- a/include/configs/cm_t35.h
+++ b/include/configs/cm_t35.h
@@ -174,7 +174,7 @@
#define CONFIG_SYS_NAND_BASE NAND_BASE /* physical address */
/* to access nand at */
/* CS0 */
-#define GPMC_NAND_ECC_LP_x16_LAYOUT
+#define GPMC_NAND_ECC_LP_x8_LAYOUT
#define CONFIG_SYS_MAX_NAND_DEVICE 1 /* Max number of NAND */
/* devices */
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] cm-t35: fix incorrect NAND_ECC layout selection
2012-07-02 12:27 [U-Boot] [PATCH] cm-t35: fix incorrect NAND_ECC layout selection Nikita Kiryanov
@ 2012-07-02 16:06 ` Tom Rini
2012-07-04 7:27 ` Nikita Kiryanov
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rini @ 2012-07-02 16:06 UTC (permalink / raw)
To: u-boot
On Mon, Jul 02, 2012 at 03:27:59PM +0300, Nikita Kiryanov wrote:
> The current configuration selects an incorrect NAND ECC layout,
> which causes u-boot to write HW ECC data incorrectly.
> This patch selects the right layout.
>
> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
This change is correct on all boards and not due to a change in NAND
parts used in newer revisions or anything, correct?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120702/16bea79d/attachment.pgp>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] cm-t35: fix incorrect NAND_ECC layout selection
2012-07-02 16:06 ` Tom Rini
@ 2012-07-04 7:27 ` Nikita Kiryanov
0 siblings, 0 replies; 3+ messages in thread
From: Nikita Kiryanov @ 2012-07-04 7:27 UTC (permalink / raw)
To: u-boot
On 07/02/2012 07:06 PM, Tom Rini wrote:
> On Mon, Jul 02, 2012 at 03:27:59PM +0300, Nikita Kiryanov wrote:
>
>> The current configuration selects an incorrect NAND ECC layout,
>> which causes u-boot to write HW ECC data incorrectly.
>> This patch selects the right layout.
>>
>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
>
> This change is correct on all boards and not due to a change in NAND
> parts used in newer revisions or anything, correct?
>
Yes. All our boards have 8 bit NAND chips.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-04 7:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-02 12:27 [U-Boot] [PATCH] cm-t35: fix incorrect NAND_ECC layout selection Nikita Kiryanov
2012-07-02 16:06 ` Tom Rini
2012-07-04 7:27 ` Nikita Kiryanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox