[U-Boot] [PATCH v2 03/14] arm/km: convert mgcoge3un target to km_kirkwood

Detlev Zundel
2012-07-03T14:00:05Z

Hi Prafulla,

[...]

>> But 01-08 are not only bugfixes there are also two new boards in these
>> patches.
>> So will you pull these eight patches in if I post them again without
>> 09-14?
>
> Pls post bug fixes and improvement patches first those will be pulled
> faster.

May I please ask you to reconsider your stance on the patch sets from
Holger? As far as I can see, he explained a few times by now why and
how he grouped the patches like he did. And to be honest, I _can_
understand his reasoning and believe it to be well-founded.

After all, our requirements come from _practical_ considerations,
i.e. bisectability, code size reductions, etc. but in the end they are
all compromises in one way or another. So usually we do not invent new
requirements for the sake of requirements, but in order to improve the
situation if the net effect is positive for the project as a whole.

Of course it is a fact that the effort for reviewers is non-negligible,
but we have to draw a line somewhere in the area where the
"well-formedness" of patch sets and the "ease" of reviewing them needs
to be compromised. I do not like to see added complexity in patch sets
so that reviewing gets easier.

As far as I can see, this is the current situation and thus I would like
you to reconsider and rather spend some more time on the review process
of the whole patch series as it is.

Thanks in advance
Detlev

--
"The number you have dialed is imaginary. Please rotate your phone 90
degrees and try again."
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de