From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 01/25] mxc_i2c: fix i2c_imx_stop
Date: Thu, 05 Jul 2012 13:02:55 -0700 [thread overview]
Message-ID: <4FF5F2EF.2070206@boundarydevices.com> (raw)
In-Reply-To: <1341518043-26191-1-git-send-email-troy.kisky@boundarydevices.com>
On 7/5/2012 12:53 PM, Troy Kisky wrote:
> Instead of clearing 2 bits, all the other
> bits were set because '|=' was used instead
> of '&='.
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> Acked-by: Marek Vasut <marex@denx.de>
> Acked-by: Stefano Babic <sbabic@denx.de>
>
> ---
> V2: add acks
> ---
> drivers/i2c/mxc_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
> index fc68062..c0c45fd 100644
> --- a/drivers/i2c/mxc_i2c.c
> +++ b/drivers/i2c/mxc_i2c.c
> @@ -264,7 +264,7 @@ void i2c_imx_stop(void)
>
> /* Stop I2C transaction */
> temp = readb(&i2c_regs->i2cr);
> - temp |= ~(I2CR_MSTA | I2CR_MTX);
> + temp &= ~(I2CR_MSTA | I2CR_MTX);
> writeb(temp, &i2c_regs->i2cr);
>
> i2c_imx_bus_busy(0);
This series was tested on a sabrelite and a i.mx51 board
Thanks
Troy
next prev parent reply other threads:[~2012-07-05 20:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 19:53 [U-Boot] [PATCH V2 01/25] mxc_i2c: fix i2c_imx_stop Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 02/25] mxc_i2c: remove ifdef of CONFIG_HARD_I2C Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 03/25] mxc_i2c: create tx_byte function Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 04/25] mxc_i2c: clear i2sr before waiting for bit Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 05/25] mxc_i2c: create i2c_init_transfer Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 06/25] mxc_i2c: call i2c_imx_stop on error in i2c_read/i2c_write Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 07/25] mxc_i2c.c: code i2c_probe as a 0 length i2c_write Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 08/25] mxc_i2c: combine i2c_imx_bus_busy and i2c_imx_trx_complete into wait_for_sr_state Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 09/25] mxc_i2c: remove redundant read Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 10/25] mxc_i2c: place imx_start code inline Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 11/25] mxc_i2c: place i2c_reset " Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 12/25] mxc_i2c: don't disable controller after every transaction Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 13/25] mxc_i2c: change slave addr if conflicts with destination Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 14/25] mxc_i2c: check for arbitration lost Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 15/25] mxc_i2c: add retries Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 16/25] mxc_i2c: add i2c_regs argument to i2c_imx_stop Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 17/25] mxc_i2c: prep work for multiple busses support Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 18/25] mxc_i2c: add bus recovery support Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 19/25] mxc_i2c: finish adding CONFIG_I2C_MULTI_BUS support Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 20/25] iomux-v3: remove include of mx6x_pins.h Troy Kisky
2012-07-05 19:53 ` [U-Boot] [PATCH V2 21/25] i.mx: iomux-v3.h: move to imx-common include directory Troy Kisky
2012-07-05 19:54 ` [U-Boot] [PATCH V2 22/25] i.mx: iomux-v3.c: move to imx-common directory Troy Kisky
2012-07-05 19:54 ` [U-Boot] [PATCH V2 23/25] i.mx53: add definition for I2C3_BASE_ADDR Troy Kisky
2012-07-05 19:54 ` [U-Boot] [PATCH V2 24/25] imx-common: add i2c.c for bus recovery support Troy Kisky
2012-07-05 19:54 ` [U-Boot] [PATCH V2 25/25] mx6qsabrelite: add i2c multi-bus support Troy Kisky
2012-07-05 20:02 ` Troy Kisky [this message]
2012-07-06 6:50 ` [U-Boot] [PATCH V2 01/25] mxc_i2c: fix i2c_imx_stop Marek Vasut
2012-07-06 17:38 ` Troy Kisky
2012-07-06 17:46 ` Marek Vasut
2012-07-06 18:14 ` Troy Kisky
2012-07-06 18:39 ` Marek Vasut
2012-07-06 23:08 ` Marek Vasut
2012-07-07 1:52 ` Troy Kisky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF5F2EF.2070206@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox