From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhong Hongbo Date: Fri, 06 Jul 2012 19:31:02 +0800 Subject: [U-Boot] [PATCH] armv7: Fix to mistake clean the memory space In-Reply-To: <4FF5B834.4050904@gmail.com> References: <1341498915-19127-1-git-send-email-bocui107@gmail.com> <4FF5B50A.9010500@gmail.com> <4FF5B834.4050904@gmail.com> Message-ID: <4FF6CC76.5030603@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/05/2012 11:52 PM, Andreas Bie?mann wrote: > On 05.07.2012 17:38, Andreas Bie?mann wrote: > > > >>> -clbss_l:str r2, [r0] /* clear loop... */ >>> +clbss_l: >>> + cmp r1, r0 >>> + bls clbss_end >>> + str r2, [r0] /* clear loop... */ >>> add r0, r0, #4 >>> - cmp r0, r1 >>> - bne clbss_l >>> + b clbss_l >>> +clbss_end: >> >> Looks sane, I maybe had checked before clbss_l, jumped over clear loop >> if r0 and r1 equal (to emphasize the fact that this is a check for entry >> correctness) and wouldn't change the loop at all. To be more precise we >> could also check if end is after start. > > Well, I just realized you do check for less ;) > Yes, Thanks, hongbo