From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] armv7: Fix to mistake clean the memory space
Date: Fri, 06 Jul 2012 15:57:03 +0200 [thread overview]
Message-ID: <4FF6EEAF.2020503@gmail.com> (raw)
In-Reply-To: <4FF6ED0C.10803@gmail.com>
Dear Zhong Hongbo,
On 06.07.2012 15:50, Zhong Hongbo wrote:
> On 07/06/2012 09:23 PM, Andreas Bie?mann wrote:
>> On 06.07.2012 14:20, Zhong Hongbo wrote:
>>> From: Zhong Hongbo <bocui107@gmail.com>
>>>
>>> In currently, when __bss_start is equal to __bss_end__,
>>> The bss loop will clear all the things in memory space.
>>>
>>> But just only when __bss_end__ greater than __bss_start__,
>>> we do the clear bss section operation.
>>>
>>> Signed-off-by: Hongbo Zhong <bocui107@gmail.com>
>>> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
>>
>> well this is wrong, I would maybe ack it
>
> Ok
After sending I doubt my statement was correct, but I found a source
http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags
>>
>>> Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
>>> ---
>>
>> Some more formal things ...
>>
>> This is the third version of this type of patch. Therefore it should
>> have a version history here and some version information in the subject
>> ([PATCH v3] maybe). Please read http://www.denx.de/wiki/view/U-Boot/Patches
>> especially
>> http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
>>
>
> Thanks, I just see the format of patch. I will add the version
> information to the next review.
>
>> BTW: The content looks sane.
>>
>
> I will send v3 for this.
a last formal thing to mention: The subject should (now) say 'arm: ...'
not 'armv7: ...'.
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2012-07-06 13:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 12:20 [U-Boot] [PATCH] armv7: Fix to mistake clean the memory space Zhong Hongbo
2012-07-06 13:23 ` Andreas Bießmann
2012-07-06 13:50 ` Zhong Hongbo
2012-07-06 13:57 ` Andreas Bießmann [this message]
2012-07-06 14:04 ` Zhong Hongbo
2012-07-06 15:26 ` Albert ARIBAUD
2012-07-06 15:29 ` Zhong Hongbo
[not found] ` <4FF704DB.4050305@gmail.com>
2012-07-07 7:29 ` Andreas Bießmann
2012-07-07 9:47 ` Zhong Hongbo
-- strict thread matches above, loose matches on Subject: below --
2012-07-05 14:35 Zhong Hongbo
2012-07-05 15:38 ` Andreas Bießmann
2012-07-05 15:52 ` Andreas Bießmann
2012-07-06 11:31 ` Zhong Hongbo
2012-07-06 11:30 ` Zhong Hongbo
2012-07-06 5:44 ` Albert ARIBAUD
2012-07-06 11:35 ` Zhong Hongbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF6EEAF.2020503@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox