From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhong Hongbo Date: Fri, 06 Jul 2012 22:04:21 +0800 Subject: [U-Boot] [PATCH] armv7: Fix to mistake clean the memory space In-Reply-To: <4FF6EEAF.2020503@gmail.com> References: <1341577211-5563-1-git-send-email-bocui107@gmail.com> <4FF6E6EA.8070401@gmail.com> <4FF6ED0C.10803@gmail.com> <4FF6EEAF.2020503@gmail.com> Message-ID: <4FF6F065.8080208@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/06/2012 09:57 PM, Andreas Bie?mann wrote: > Dear Zhong Hongbo, > > On 06.07.2012 15:50, Zhong Hongbo wrote: >> On 07/06/2012 09:23 PM, Andreas Bie?mann wrote: >>> On 06.07.2012 14:20, Zhong Hongbo wrote: >>>> From: Zhong Hongbo >>>> >>>> In currently, when __bss_start is equal to __bss_end__, >>>> The bss loop will clear all the things in memory space. >>>> >>>> But just only when __bss_end__ greater than __bss_start__, >>>> we do the clear bss section operation. >>>> >>>> Signed-off-by: Hongbo Zhong >>>> Signed-off-by: Andreas Bie?mann >>> >>> well this is wrong, I would maybe ack it >> >> Ok > > After sending I doubt my statement was correct, but I found a source > http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags he, Ye, I think we(You, Albert and me) are involved in the development of the patch. > >>> >>>> Signed-off-by: Albert ARIBAUD >>>> --- >>> >>> Some more formal things ... >>> >>> This is the third version of this type of patch. Therefore it should >>> have a version history here and some version information in the subject >>> ([PATCH v3] maybe). Please read http://www.denx.de/wiki/view/U-Boot/Patches >>> especially >>> http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions >>> >> >> Thanks, I just see the format of patch. I will add the version >> information to the next review. >> >>> BTW: The content looks sane. >>> >> >> I will send v3 for this. > > a last formal thing to mention: The subject should (now) say 'arm: ...' > not 'armv7: ...'. Ok. Thanks, hongbo > > Best regards > > Andreas Bie?mann > >