From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhong Hongbo Date: Sat, 07 Jul 2012 17:47:57 +0800 Subject: [U-Boot] [PATCH] armv7: Fix to mistake clean the memory space In-Reply-To: <4FF7E546.8040909@googlemail.com> References: <1341577211-5563-1-git-send-email-bocui107@gmail.com> <4FF6E6EA.8070401@gmail.com> <4FF6ED0C.10803@gmail.com> <4FF6EEAF.2020503@gmail.com> <4FF704DB.4050305@gmail.com> <4FF7E546.8040909@googlemail.com> Message-ID: <4FF805CD.5080605@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/07/2012 03:29 PM, Andreas Bie?mann wrote: > Dear Zhong Hongbo, > > Am Freitag, 6. Juli 2012 schrieb Zhong Hongbo : > > On 07/06/2012 09:57 PM, Andreas Bie?mann wrote: > > Dear Zhong Hongbo, > > > > On 06.07.2012 15:50, Zhong Hongbo wrote: > >> On 07/06/2012 09:23 PM, Andreas Bie?mann wrote: > >>> On 06.07.2012 14:20, Zhong Hongbo wrote: > >>>> From: Zhong Hongbo > > >>>> > >>>> In currently, when __bss_start is equal to __bss_end__, > >>>> The bss loop will clear all the things in memory space. > >>>> > >>>> But just only when __bss_end__ greater than __bss_start__, > >>>> we do the clear bss section operation. > >>>> > >>>> Signed-off-by: Hongbo Zhong > > >>>> Signed-off-by: Andreas Bie?mann > > >>> > >>> well this is wrong, I would maybe ack it > Hi Andreas, > > How I do it? Signed-off-by or Reviewed-by? > > > you do not need to put these lines in at all, the reviewer will reply > your mail with the correct line (Acked-by, Reviewed-by, Tested-by) in > it. A tool called patchwork will then provide some convenience for the > custodians. He just pulls the mbox file from patchwork which has all the > collected lines in it. The resulting commit in the custodian repository > will contain all these linesgathered while in review process. > You ought to put some other people on cc so they can review the patch. > This can easily achieved by putting a 'cc: ' into the patch. > Git will then put these addresses on cc automagicly. Ok, Thanks, hongbo > > Best regards > > Andreas Bie?mann > >