From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuyuki Kobayashi Date: Mon, 09 Jul 2012 11:42:15 +0900 Subject: [U-Boot] [PATCH] net: bugfix: NetSetTimeout assumes CONFIG_SYS_HZ=1000 In-Reply-To: <20120708195848.1A52E202D56@gemini.denx.de> References: <4FE85B87.6090302@kmckk.co.jp> <20120708195848.1A52E202D56@gemini.denx.de> Message-ID: <4FFA4507.1050303@kmckk.co.jp> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang Denk, (07/09/2012 04:58 AM), Wolfgang Denk wrote: > Dear Tetsuyuki Kobayashi, > > In message <4FE85B87.6090302@kmckk.co.jp> you wrote: >> NetSetTimeout sets incorrect value to timeDelta when CONFIG_SYS_HZ != 1000. > > Your patch is OK per se, but please note that it is a mandatory > requirement that CONFIG_SYS_HZ == 1000. So if you have any board > where this is not the case, this board needs to be fixed, too. Thank you for reviewing my patch. I didn't know that it is a mandatory requirement that CONFIG_SYS_HZ == 1000. I grep'ed for CONFIG_SYS_HZ in README and under doc/, but I could not find any description about it. $ grep -r CONFIG_SYS_HZ README doc/* doc/README.LED:(CONFIG_SYS_HZ / ) where is the frequency of the blink. Typical values And I couldn't find that what value should be return in ulong get_timer(ulong base); I hope "how to implement system timer" documented. Best regards, Tetsuyuki Kobayashi