From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration
Date: Mon, 09 Jul 2012 16:44:31 +0200 [thread overview]
Message-ID: <4FFAEE4F.3090600@keymile.com> (raw)
In-Reply-To: <m2zk79nkx6.fsf@lamuella.denx.de>
Hi Detlev,
On 07/09/2012 03:06 PM, Detlev Zundel wrote:
>> If we place the driver in your board diretory, the chances are huge it
>> will simply sit there and rot, and the next one who needs something
>> similar will reinvent the wheel because he did not find your copy.
>>
>> I agree that even very simple and uncomplete implementations can co in
>> if the fulfil some purpose, and can form a basis for future
>> extensions.
>
> I just read through our documentation on the Wiki and found nothing
> relavant to such a topic. If we make this a requirement, we should add
> it so people know about it beforehand.
>
> How about amending the U-Boot design principles with
>
> 11. Keep It Generic
>
> - Generic code shall be added as high as possible to the U-Boot
> abstraction hierarchy and only as a last resort into board
> directories. This entails that peripheral drivers should be put below
> "drivers" even if they start out supporting only one specific
> configuration. Note that it is not a requirement for such a first
> instance to be generic as genericity generally cannot be extrapolated
> from a single data point.
>
> How does that sound?
>
shouldn't be there an exception for strictly board specific peripheral drivers
like an custom-made FPGA?
Regards
Holger
next prev parent reply other threads:[~2012-07-09 14:44 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 10:06 [U-Boot] [PATCH 00/20] updates for Keymile Marvell boards Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 01/20] arm/km: enable spi claim bus Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 02/20] arm/km: use correct kw_gpio function for NAND/SPI switching Valentin Longchamp
2012-06-12 4:39 ` Prafulla Wadaskar
2012-06-12 8:38 ` Holger Brunck
2012-06-12 9:32 ` Prafulla Wadaskar
2012-06-12 10:29 ` Holger Brunck
2012-06-13 12:16 ` Holger Brunck
2012-06-07 10:06 ` [U-Boot] [PATCH 03/20] arm/kirkwood: protect the ENV_SPI #defines Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 04/20] arm/km: add kmnusa board support Valentin Longchamp
2012-06-12 4:39 ` Prafulla Wadaskar
2012-06-12 8:34 ` Holger Brunck
2012-06-12 9:40 ` Prafulla Wadaskar
2012-06-12 10:30 ` Holger Brunck
2012-06-12 9:45 ` Prafulla Wadaskar
2012-06-12 9:57 ` Prafulla Wadaskar
2012-06-12 10:37 ` Holger Brunck
2012-06-12 11:09 ` Prafulla Wadaskar
2012-06-12 11:43 ` Holger Brunck
2012-06-12 11:50 ` Prafulla Wadaskar
2012-06-12 15:20 ` Holger Brunck
2012-06-07 10:06 ` [U-Boot] [PATCH 05/20] arm/km: add kmcoge5un " Valentin Longchamp
2012-06-12 4:39 ` Prafulla Wadaskar
2012-06-07 10:06 ` [U-Boot] [PATCH 06/20] arm/km: convert mgcoge3un target to km_kirkwood Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 07/20] arm/km: remove portl2.h and use km_kirkwood instead Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 08/20] arm/km: correct init of 88e6352 switch in the reset_phy function Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 09/20] arm/km: enable BOCO2 FPGA download support Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 10/20] arm/km: cleanup km_kirkwood boards Valentin Longchamp
2012-06-12 4:39 ` Prafulla Wadaskar
2012-06-12 8:15 ` Holger Brunck
2012-06-07 10:06 ` [U-Boot] [PATCH 11/20] arm/km: redefine piggy 4 reg names to avoid conflicts Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 12/20] arm/km: add support for external switch configuration Valentin Longchamp
2012-06-12 4:39 ` Prafulla Wadaskar
2012-06-21 13:09 ` [U-Boot] [PATCH 12/20] arm/km: add support for external switchconfiguration Valentin Longchamp
2012-07-03 8:17 ` Prafulla Wadaskar
2012-07-03 9:51 ` Valentin Longchamp
2012-07-04 8:07 ` Detlev Zundel
2012-07-04 9:20 ` Prafulla Wadaskar
2012-07-09 12:04 ` Holger Brunck
2012-07-09 12:31 ` Wolfgang Denk
2012-07-09 12:50 ` Detlev Zundel
2012-07-09 19:29 ` Wolfgang Denk
2012-07-09 13:06 ` Detlev Zundel
2012-07-09 14:44 ` Holger Brunck [this message]
2012-07-09 19:44 ` Wolfgang Denk
2012-07-09 19:32 ` Wolfgang Denk
2012-07-16 16:55 ` Detlev Zundel
2012-07-09 20:42 ` Prafulla Wadaskar
2012-07-10 19:33 ` Joe Hershberger
2012-07-09 14:31 ` Detlev Zundel
2012-07-09 14:40 ` Valentin Longchamp
2012-07-10 10:18 ` Prafulla Wadaskar
2012-06-07 10:06 ` [U-Boot] [PATCH 13/20] arm/km: enable external switch configuration for kmnusa Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 14/20] arm/km: skip FPGA config when already configured Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 15/20] arm/km: support the 2 PCIe fpga resets Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 16/20] arm/km: add implementation for read_dip_switch Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 17/20] arm/km: fix testpin detection for kmcoge5un Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 18/20] arm/km: implement weak function board_spi_clam_bus/release Valentin Longchamp
2012-06-07 10:06 ` [U-Boot] [PATCH 19/20] arm/km: remove spi toggle command Valentin Longchamp
2012-06-07 10:07 ` [U-Boot] [PATCH 20/20] arm/km: remove calls to kw_gpio_* in board_early_init_f Valentin Longchamp
2012-06-12 7:58 ` Prafulla Wadaskar
2012-06-12 8:43 ` Holger Brunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFAEE4F.3090600@keymile.com \
--to=holger.brunck@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox