From: Dirk Behme <dirk.behme@de.bosch.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/1] net: phy: micrel: make ksz9021 phy accessible
Date: Wed, 11 Jul 2012 08:53:08 +0200 [thread overview]
Message-ID: <4FFD22D4.5080505@de.bosch.com> (raw)
In-Reply-To: <4FFCCE9C.9080508@boundarydevices.com>
On 11.07.2012 02:53, Troy Kisky wrote:
> On 6/28/2012 11:00 AM, Troy Kisky wrote:
>> Micrel accidentally used the same part number
>> for the KS8721 and KSZ9021. So, both cannot be
>> in the same build of u-boot. Add a config option
>> to handle this.
>>
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>> Acked-by: Vladimir Zapolskiy <vz@mleia.com>
>>
>> ---
>> v2: add ack
>> ---
>> drivers/net/phy/micrel.c | 15 +++++++++++++--
>> include/configs/mx6qsabrelite.h | 1 +
>> 2 files changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
>> index e3043df..30f3264 100644
>> --- a/drivers/net/phy/micrel.c
>> +++ b/drivers/net/phy/micrel.c
>> @@ -35,6 +35,12 @@ static struct phy_driver KSZ804_driver = {
>> .shutdown = &genphy_shutdown,
>> };
>>
>> +#ifndef CONFIG_PHY_MICREL_KSZ9021
>> +/*
>> + * I can't believe Micrel used the exact same part number
>> + * for the KSZ9021
>> + * Shame Micrel, Shame!!!!!
>> + */
>> static struct phy_driver KS8721_driver = {
>> .name = "Micrel KS8721BL",
>> .uid = 0x221610,
>> @@ -44,7 +50,9 @@ static struct phy_driver KS8721_driver = {
>> .startup = &genphy_startup,
>> .shutdown = &genphy_shutdown,
>> };
>> +#endif
>>
>> +#ifdef CONFIG_PHY_MICREL_KSZ9021
>> /* ksz9021 PHY Registers */
>> #define MII_KSZ9021_EXTENDED_CTRL 0x0b
>> #define MII_KSZ9021_EXTENDED_DATAW 0x0c
>> @@ -127,12 +135,15 @@ static struct phy_driver ksz9021_driver = {
>> .startup = &ksz9021_startup,
>> .shutdown = &genphy_shutdown,
>> };
>> +#endif
>>
>> int phy_micrel_init(void)
>> {
>> phy_register(&KSZ804_driver);
>> - phy_register(&KS8721_driver);
>> +#ifdef CONFIG_PHY_MICREL_KSZ9021
>> phy_register(&ksz9021_driver);
>> -
>> +#else
>> + phy_register(&KS8721_driver);
>> +#endif
>> return 0;
>> }
>> diff --git a/include/configs/mx6qsabrelite.h b/include/configs/mx6qsabrelite.h
>> index feabc05..8623320 100644
>> --- a/include/configs/mx6qsabrelite.h
>> +++ b/include/configs/mx6qsabrelite.h
>> @@ -97,6 +97,7 @@
>> #define CONFIG_FEC_MXC_PHYADDR 6
>> #define CONFIG_PHYLIB
>> #define CONFIG_PHY_MICREL
>> +#define CONFIG_PHY_MICREL_KSZ9021
>>
>> /* USB Configs */
>> #define CONFIG_CMD_USB
> ping....
Yes, ping from me, too.
Thanks
Dirk
next prev parent reply other threads:[~2012-07-11 6:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 18:00 [U-Boot] [PATCH V2 1/1] net: phy: micrel: make ksz9021 phy accessible Troy Kisky
2012-07-11 0:53 ` Troy Kisky
2012-07-11 6:53 ` Dirk Behme [this message]
2012-07-11 8:28 ` Prafulla Wadaskar
2012-07-11 18:35 ` Joe Hershberger
2012-07-11 18:54 ` Troy Kisky
2012-07-11 18:59 ` Joe Hershberger
2012-07-11 18:36 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD22D4.5080505@de.bosch.com \
--to=dirk.behme@de.bosch.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox