From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt: Include arch specific gpio.h
Date: Wed, 11 Jul 2012 14:21:58 +0200 [thread overview]
Message-ID: <4FFD6FE6.6090905@monstr.eu> (raw)
In-Reply-To: <CAPnjgZ3hZJD0X-pL0LNPPwJDoiMLBh8zur5+NH=9O1NQ2PATXw@mail.gmail.com>
On 07/11/2012 02:00 PM, Simon Glass wrote:
> Hi Michal,
>
> On Wed, Jul 11, 2012 at 1:21 PM, Michal Simek <monstr at monstr.eu <mailto:monstr@monstr.eu>> wrote:
>
> On 07/11/2012 12:59 PM, Simon Glass wrote:
>
> Hi,
>
>
> On Wed, Jul 11, 2012 at 12:43 PM, Michal Simek <monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>>> wrote:
>
> On 07/11/2012 11:59 AM, Simon Glass wrote:
>
> Hi Michal,
>
>
> On Wed, Jul 11, 2012 at 10:19 AM, Michal Simek <monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>>>> wrote:
>
> On 07/10/2012 11:13 PM, Simon Glass wrote:
>
> Hi Michal,
>
>
> On Tue, Jul 10, 2012 at 11:56 AM, Michal Simek <monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>>> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>>>>> wrote:
>
> Also include arch specific gpio.h which can contain
> gpio function implementation.
>
> Signed-off-by: Michal Simek <monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>>> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu> <mailto:monstr at monstr.eu <mailto:monstr@monstr.eu>>>>>
> CC: Simon Glass <sjg at chromium.org <mailto:sjg@chromium.org> <mailto:sjg at chromium.org <mailto:sjg@chromium.org>> <mailto:sjg at chromium.org <mailto:sjg@chromium.org> <mailto:sjg at chromium.org <mailto:sjg@chromium.org>>> <mailto:sjg at chromium.org <mailto:sjg@chromium.org> <mailto:sjg at chromium.org <mailto:sjg@chromium.org>> <mailto:sjg at chromium.org <mailto:sjg@chromium.org> <mailto:sjg at chromium.org <mailto:sjg@chromium.org>>>>>
>
>
>
> ---
> lib/fdtdec.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
> index cc09e06..b12eb77 100644
> --- a/lib/fdtdec.c
> +++ b/lib/fdtdec.c
> @@ -25,6 +25,7 @@
> #include <fdtdec.h>
>
> /* we need the generic GPIO interface here */
> +#include <asm/gpio.h>
>
>
> Can you not instead support the generic functions? What are you missing from from there that fdtdec.c needs?
>
>
> OK. The problem is with fdtdec_setup_gpio function where you called gpio_request which
> is gpio specific function which you haven't included.
>
> The most archs have this defined in arch/<cpuname>/include/asm/______gpio.h.
>
>
>
>
> This is there in my tree. Please see commit:
>
> 5f533aeb gpio: Modify common gpio.h to more closely match Linux
>
>
> This is generic gpio cleanup but I don't think this is the same thing.
> I think you should get some warnings for fdtdec compilation around missing gpio_request
> declaration or you include gpio.h in any other header file which is in fdtdec.c/h.
>
>
> Sorry I don't really understand that. For me fdtdec.c has #include <asm-generic/gpio.h> and that is enough to get gpio_request(). Can you please advise what warning you see and for what board?
>
>
> Microblaze:
> lib/libgeneric.o: In function `fdtdec_setup_gpio':
> /mnt/projects/u-boot/lib/__fdtdec.c:477: undefined reference to `gpio_request'
>
> The same error will be for nios2, openrisc and blackfin because they define
> gpio_request as static inline function in arch/<arch>/include/asm/gpio.h
>
> Because I think there should be asm/gpio.h included which can include asm-generic/gpio.h
> (this is arm case).
>
>
> OK I see, that makes sense.
>
>
> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
> index cc09e06..50a5061 100644
> --- a/lib/fdtdec.c
> +++ b/lib/fdtdec.c
> @@ -25,7 +25,7 @@
>
> #include <fdtdec.h>
>
> /* we need the generic GPIO interface here */
>
>
> Can we remove this comment then?
Yes, we can! :-)
I will create proper patch.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
next prev parent reply other threads:[~2012-07-11 12:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 9:56 [U-Boot] [PATCH] fdt: Include arch specific gpio.h Michal Simek
2012-07-10 21:13 ` Simon Glass
2012-07-11 8:19 ` Michal Simek
2012-07-11 9:59 ` Simon Glass
2012-07-11 10:43 ` Michal Simek
2012-07-11 10:59 ` Simon Glass
2012-07-11 11:21 ` Michal Simek
2012-07-11 12:00 ` Simon Glass
2012-07-11 12:21 ` Michal Simek [this message]
2012-07-11 21:02 ` Joe Hershberger
2012-07-12 5:05 ` Simon Glass
2012-07-12 5:33 ` Michal Simek
2012-07-12 5:38 ` Simon Glass
2012-07-12 16:37 ` Joe Hershberger
2012-07-13 5:43 ` Michal Simek
-- strict thread matches above, loose matches on Subject: below --
2012-06-29 7:28 Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD6FE6.6090905@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox