From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zhong Hongbo <bocui107@gmail.com>
Date: Wed, 11 Jul 2012 20:34:26 +0800
Subject: [U-Boot] [PATCH 02/13] S3C64XX: Switch to use readl/writel to
 operate nand flash
In-Reply-To: <4FFC4BEB.3020209@freescale.com>
References: <1341655032-30201-1-git-send-email-bocui107@gmail.com>
	<1341655032-30201-3-git-send-email-bocui107@gmail.com>
	<4FFB5902.3040305@freescale.com> <4FFC2015.508@gmail.com>
	<4FFC2786.7000204@gmail.com> <4FFC4BEB.3020209@freescale.com>
Message-ID: <4FFD72D2.1080505@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Scott,

On 07/10/2012 11:36 PM, Scott Wood wrote:
> On 07/10/2012 08:00 AM, Zhong Hongbo wrote:
>> On 07/10/2012 08:29 PM, Zhong Hongbo wrote:
>>> On 07/10/2012 06:19 AM, Scott Wood wrote:
>>>> On 07/07/2012 04:57 AM, Zhong Hongbo wrote:
>>>>> @@ -89,15 +96,16 @@ static void s3c_nand_select_chip(struct mtd_info *mtd, int chip)
>>>>>   */
>>>>>  static void s3c_nand_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int ctrl)
>>>>>  {
>>>>> +	struct s3c64xx_nand *const nand = s3c_get_base_nand();
>>>>
>>>> Is there any benefit to declaring local variables const like this?
>>>
>>> I reference the nand driver of S5PXX CPU. So ...
>> Sorry, I make a mistake, The S5PXX have not nand flash support. When i
>> do the patch, I use the format as following?
>>
>> struct s3c64xx_nand *nand = s3c_get_base_nand();
>>
>> But when I use checkpatch.pl script to check the patch. more and more
>> waring about the line, it said that you should add 'const' before nand
>> variable.
> 
> Could you paste the exact output from checkpatch.pl?

Just redo the patch, I can not reproduce the issue. Thank you for your
point.

Thanks,
hongbo
> 
> -Scott
> 
> 
>