From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Wed, 11 Jul 2012 11:54:41 -0700 Subject: [U-Boot] [PATCH V2 1/1] net: phy: micrel: make ksz9021 phy accessible In-Reply-To: References: <1340906428-30738-1-git-send-email-troy.kisky@boundarydevices.com> <4FFCCE9C.9080508@boundarydevices.com> <4FFD22D4.5080505@de.bosch.com> Message-ID: <4FFDCBF1.5020208@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 7/11/2012 1:28 AM, Prafulla Wadaskar wrote: > >> -----Original Message----- >> From: u-boot-bounces at lists.denx.de [mailto:u-boot- >> bounces at lists.denx.de] On Behalf Of Dirk Behme >> Sent: 11 July 2012 12:23 >> To: u-boot at lists.denx.de; Joe Hershberger >> Subject: Re: [U-Boot] [PATCH V2 1/1] net: phy: micrel: make ksz9021 >> phy accessible >> >> On 11.07.2012 02:53, Troy Kisky wrote: >>> On 6/28/2012 11:00 AM, Troy Kisky wrote: >>>> Micrel accidentally used the same part number >>>> for the KS8721 and KSZ9021. So, both cannot be >>>> in the same build of u-boot. Add a config option >>>> to handle this. >>>> >>>> Signed-off-by: Troy Kisky >>>> Acked-by: Vladimir Zapolskiy >>>> >>>> --- >>>> v2: add ack >>>> --- >>>> drivers/net/phy/micrel.c | 15 +++++++++++++-- >>>> include/configs/mx6qsabrelite.h | 1 + >>>> 2 files changed, 14 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c >>>> index e3043df..30f3264 100644 >>>> --- a/drivers/net/phy/micrel.c >>>> +++ b/drivers/net/phy/micrel.c >>>> @@ -35,6 +35,12 @@ static struct phy_driver KSZ804_driver = { >>>> .shutdown = &genphy_shutdown, >>>> }; >>>> >>>> +#ifndef CONFIG_PHY_MICREL_KSZ9021 >>>> +/* >>>> + * I can't believe Micrel used the exact same part number >>>> + * for the KSZ9021 >>>> + * Shame Micrel, Shame!!!!! > These comments attracted my attention. I doubt these are valid comments that should get mainlined??? > > Regards... > Prafulla . . . > Yeah, I was a little pissed when I found this problem. Joe, do you want me to tone down the language? I still think Micrel should be very embarrassed to have done such a thing. Thanks Troy