public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm: cm4008, cm41xx: set gd->ram_size in dram_init
Date: Thu, 12 Jul 2012 11:32:36 +0200	[thread overview]
Message-ID: <4FFE99B4.4090800@gmail.com> (raw)
In-Reply-To: <4FFC1DDF.2060903@opengear.com>

On 10.07.2012 14:19, Greg Ungerer wrote:
> On 07/10/2012 07:58 AM, Albert ARIBAUD wrote:
>> Hi Andreas,
>>
>> On Fri, 06 Jul 2012 12:25:00 +0200, "Andreas Bie?mann"
>> <andreas.devel@googlemail.com> wrote:
>>> Dear Yann Vernier,
>>>
>>> On 06.07.2012 11:14, Yann Vernier wrote:
>>>> On Friday 06 July 2012 10:43:40 you wrote:

<snip>

>>>>
>>>> Could I save the value decoding and corresponding configuration
>>>> changes for a
>>>> fourth patch?
>>>
>>> I'm fine with this suggestion.
>>> So the next question is who would pull it in mainline? Since this is arm
>>> related I guess Albert is the one in question.
>>
>> Ah, board-related patches. :)
>>
>>> I think these three patches are all fixes to get a board already in
>>> mainline working.
> 
> Fixes or improvements?

I think these are fixes cause the board seems to not working without
these changes.

>> So I think we should try to get these in -rc1.
>>> Albert, can you please comment?
>>
>> If the cm4008/cm41xx board maintainer (as per MAINTAINERS, this is
>> Greg Ungerer,
>> Cc:) green-lights it, then I'm ok for pulling it in.
> 
> I have no problem with them. I have only done a visual inspection of the
> revised patches in the mail archives, and not tested them on the real
> hardware.
> 
> I would suggest defining the proper meanings of the remaining bits in
> the SDRAM setup registers that are still magic numbers, but that can be
> a future change.

Definitely.

Best regards

Andreas Bie?mann

  reply	other threads:[~2012-07-12  9:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-06  8:15 [U-Boot] [PATCH v2] arm: cm4008, cm41xx: set gd->ram_size in dram_init Yann Vernier
2012-07-06  8:43 ` Andreas Bießmann
2012-07-06  9:14   ` Yann Vernier
2012-07-06 10:25     ` Andreas Bießmann
2012-07-09 21:58       ` Albert ARIBAUD
2012-07-10 12:19         ` Greg Ungerer
2012-07-12  9:32           ` Andreas Bießmann [this message]
2012-07-12  9:30         ` Andreas Bießmann
  -- strict thread matches above, loose matches on Subject: below --
2012-07-05 10:02 [U-Boot] [PATCH 1/3] cm4008: " Andreas Bießmann
2012-07-05 12:11 ` [U-Boot] [PATCH v2] arm: cm4008, cm41xx: " Yann Vernier
2012-07-05 14:48   ` Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFE99B4.4090800@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox