From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Thu, 12 Jul 2012 17:44:53 -0500 Subject: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location In-Reply-To: <4FFF51A9.5060500@freescale.com> References: <1342129594-7861-1-git-send-email-timur@freescale.com> <9F5356FB-8CA2-44DE-9089-64ABD82CA733@freescale.com> <4FFF51A9.5060500@freescale.com> Message-ID: <4FFF5365.20709@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Scott Wood wrote: >> > That patch itself is OK. But the comment is incorrect. We keep adding more mac addresses to this data structure. The CRC was at the end. The offset 0xCC was correct. > Is there anything in the data structure to indicate that this growth has > happened? The version number indicates whether it's 8 addresses (v0) or more than 8 (v1). The problem is that I think I just made a math error when I calculated the number of MAC addresses that would fit in the EEPROM. I was supposed to do (0xFC - 0x72) / 6 == 31, but instead I ended up with 23, and never validated it. -- Timur Tabi Linux kernel developer at Freescale