From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location
Date: Thu, 12 Jul 2012 17:49:29 -0500 [thread overview]
Message-ID: <4FFF5479.8060208@freescale.com> (raw)
In-Reply-To: <1A7ED0F3-8897-4D3B-B7C6-0C71C3F38415@freescale.com>
On 07/12/2012 05:46 PM, sun york-R58495 wrote:
>
> On Jul 12, 2012, at 3:37 PM, Scott Wood wrote:
>
>> On 07/12/2012 05:03 PM, sun york-R58495 wrote:
>>> Timur,
>>>
>>> That patch itself is OK. But the comment is incorrect. We keep adding more mac addresses to this data structure. The CRC was at the end. The offset 0xCC was correct.
>>
>> Is there anything in the data structure to indicate that this growth has
>> happened?
>>
> Discussed with Timur. The MAX_NUM_PORT was chosen as 23, probably because of a wrong math. There is no reason to use that number. Now changing to 31 will use up all the EEPROM space and push the CRC to the end, offset 0xFC.
If the 0xCC version is already in real use, then this change should bump
the version number.
-Scott
next prev parent reply other threads:[~2012-07-12 22:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 21:46 [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location Timur Tabi
2012-07-12 22:03 ` sun york-R58495
2012-07-12 22:37 ` Scott Wood
2012-07-12 22:44 ` Timur Tabi
2012-07-12 22:46 ` sun york-R58495
2012-07-12 22:49 ` Scott Wood [this message]
2012-07-12 22:52 ` Timur Tabi
2012-07-13 4:32 ` Wolfgang Denk
2012-07-13 12:11 ` Tabi Timur-B04825
2012-07-13 21:26 ` Wolfgang Denk
2012-07-13 4:30 ` Wolfgang Denk
2012-07-13 4:38 ` sun york-R58495
2012-07-13 12:12 ` Tabi Timur-B04825
2012-07-13 21:22 ` York Sun
2012-07-13 12:10 ` Tabi Timur-B04825
2012-07-13 21:25 ` Wolfgang Denk
2012-07-13 21:29 ` Timur Tabi
2012-07-13 21:32 ` Wolfgang Denk
2012-07-13 21:39 ` Timur Tabi
2012-07-13 21:45 ` Scott Wood
2012-07-13 21:53 ` Timur Tabi
2012-07-13 22:19 ` Scott Wood
2012-07-13 22:22 ` Timur Tabi
2012-07-13 22:41 ` Scott Wood
2012-07-13 22:46 ` Timur Tabi
2012-07-13 22:54 ` Scott Wood
2012-07-13 23:01 ` Wolfgang Denk
2012-07-13 23:12 ` Scott Wood
[not found] ` <C5EFF1F960B6FC4C873CF9BD5FE250210791DCC8@039-SN2MPN1-013.039d.mgd.msft.net>
2012-07-15 12:52 ` Tabi Timur-B04825
2012-07-16 19:57 ` Wolfgang Denk
2012-07-16 22:32 ` Scott Wood
2012-07-13 22:59 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFF5479.8060208@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox