From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Fri, 13 Jul 2012 07:43:29 +0200 Subject: [U-Boot] [PATCH] fdt: Include arch specific gpio.h In-Reply-To: References: <1341914208-4159-1-git-send-email-monstr@monstr.eu> <4FFD36FD.3070300@monstr.eu> <4FFD58C9.3020802@monstr.eu> <4FFD61B7.5030008@monstr.eu> Message-ID: <4FFFB581.5080806@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Joe, >>> >>> >>> This is generic gpio cleanup but I don't think this is the same thing. >>> I think you should get some warnings for fdtdec compilation around >>> missing gpio_request >>> declaration or you include gpio.h in any other header file which is in >>> fdtdec.c/h. >>> >>> >>> Sorry I don't really understand that. For me fdtdec.c has #include >>> and that is enough to get gpio_request(). Can you >>> please advise what warning you see and for what board? >> >> >> Microblaze: >> lib/libgeneric.o: In function `fdtdec_setup_gpio': >> /mnt/projects/u-boot/lib/fdtdec.c:477: undefined reference to `gpio_request' >> >> The same error will be for nios2, openrisc and blackfin because they define >> gpio_request as static inline function in arch//include/asm/gpio.h >> >> Because I think there should be asm/gpio.h included which can include >> asm-generic/gpio.h >> (this is arm case). > > When you send an updated patch you need to add V2 or whatever to the > subject and you need to include a change log here. > > I think you meant to reject this, not the other one here: > http://patchwork.ozlabs.org/patch/170457 I have sent this patch http://lists.denx.de/pipermail/u-boot/2012-July/128257.html which has broken subject that's why I have sent this message (it took me 2-3 mins) http://lists.denx.de/pipermail/u-boot/2012-July/128259.html And also send correct patch with proper subject and changelog http://lists.denx.de/pipermail/u-boot/2012-July/128258.html http://patchwork.ozlabs.org/patch/170458/ Can you please clarify what's wrong? Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian