From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vignesh R Date: Mon, 1 Aug 2016 09:53:29 +0530 Subject: [U-Boot] [PATCH 2/4] ARM: dra7xx_evm: Enable support for TI PCF8575 In-Reply-To: References: <20160725131023.30656-1-vigneshr@ti.com> <20160725131023.30656-3-vigneshr@ti.com> <20160725133839.GI14698@bill-the-cat> <715c96ff-e364-04bc-b108-38d97a015960@ti.com> Message-ID: <4a24cea2-ef7e-aff0-fe75-ddefda6143af@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On Monday 01 August 2016 06:31 AM, Simon Glass wrote: [...] >>>> +/* PCF Support */ >>>> +#ifndef CONFIG_SPL_BUILD >>>> +#define CONFIG_PCF8575_GPIO >>>> +#endif >>> >>> We need to invert the logic and undef on SPL, and pick this up normally >>> via Kconfig. >>> >> >> I tried that initially but, the logic does not seem to work. Since, the >> driver is DM only driver, undef'ing CONFIG_PCF8575_GPIO on >> CONFIG_SPL_BUILD does seem to take any effect, the driver is still being >> compiled for SPL build and results in compile time errors. It seems that >> undef in include/configs/* file does not seem to take effect in >> Makefile, but only takes effect in the code. Any idea what am I missing? > > Can you have CONFIG_PCF8575_GPIO and CONFIG_SPL_PCF8575_GPIO? > > Then > > obj-CONFIG_$(SPL_)PCF8575_GPIO += ... Thanks! Will make changes accordingly... -- Regards Vignesh