Fwd: New Defects reported by Coverity Scan for Das U-Boot

Tom Rini
2024-10-28T03:12:07Z

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

Here's the latest report.

---------- Forwarded message ---------
From: <scan-admin@coverity.com>
Date: Sun, Oct 27, 2024 at 9:05 PM
Subject: New Defects reported by Coverity Scan for Das U-Boot
To: <tom.rini@gmail.com>

Hi,

Please find the latest report on new defect(s) introduced to Das
U-Boot found with Coverity Scan.

1 new defect(s) introduced to Das U-Boot found with Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)

** CID 511435: Integer handling issues (SIGN_EXTENSION)
/lib/acpi/acpi_table.c: 476 in acpi_write_spcr()

________________________________________________________________________________________________________
*** CID 511435: Integer handling issues (SIGN_EXTENSION)
/lib/acpi/acpi_table.c: 476 in acpi_write_spcr()
470 default:
471 space_id = ACPI_ADDRESS_SPACE_IO;
472 break;
473 }
474
475 serial_width = serial_info.reg_width * 8;
>>> CID 511435: Integer handling issues (SIGN_EXTENSION)
>>> Suspicious implicit sign extension: "serial_info.reg_offset" with type "u8" (8 bits, unsigned) is promoted in "serial_info.reg_offset << serial_info.reg_shift" to type "int" (32 bits, signed), then sign-extended to type "unsigned long" (64 bits, unsigned). If "serial_info.reg_offset << serial_info.reg_shift" is greater than 0x7FFFFFFF, the upper bits of the result will all be 1.
476 serial_offset = serial_info.reg_offset << serial_info.reg_shift;
477 serial_address = serial_info.addr + serial_offset;
478
479 /* Encode register access size */
480 switch (serial_info.reg_shift) {
481 case 0:

----- End forwarded message -----

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]