Fwd: New Defects reported by Coverity Scan for Das U-Boot

Tom Rini
2022-11-21T19:43:16Z

[-- Attachment #1: Type: text/plain, Size: 2708 bytes --]

Here's the latest report

---------- Forwarded message ---------
From: <scan-admin@coverity.com>
Date: Mon, Nov 21, 2022 at 12:44 PM
Subject: New Defects reported by Coverity Scan for Das U-Boot
To: <tom.rini@gmail.com>

Hi,

Please find the latest report on new defect(s) introduced to Das
U-Boot found with Coverity Scan.

2 new defect(s) introduced to Das U-Boot found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in
the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)

** CID 376996: Error handling issues (CHECKED_RETURN)
/drivers/net/sandbox-raw-bus.c: 40 in eth_raw_bus_post_bind()

________________________________________________________________________________________________________
*** CID 376996: Error handling issues (CHECKED_RETURN)
/drivers/net/sandbox-raw-bus.c: 40 in eth_raw_bus_post_bind()
34 if (skip_localhost && local)
35 continue;
36
37 ub_ifname = calloc(IFNAMSIZ + sizeof(ub_ifname_pfx), 1);
38 strcpy(ub_ifname, ub_ifname_pfx);
39 strncat(ub_ifname, i->if_name, IFNAMSIZ);
>>> CID 376996: Error handling issues (CHECKED_RETURN)
>>> Calling "device_bind_driver" without checking return value (as is done elsewhere 12 out of 15 times).
40 device_bind_driver(dev, "eth_sandbox_raw", ub_ifname, &child);
41
42 device_set_name_alloced(child);
43 device_probe(child);
44 priv = dev_get_priv(child);
45 if (priv) {

** CID 376995: Null pointer dereferences (FORWARD_NULL)
/test/test-main.c: 518 in ut_run_tests()

________________________________________________________________________________________________________
*** CID 376995: Null pointer dereferences (FORWARD_NULL)
/test/test-main.c: 518 in ut_run_tests()
512 pos = dectoul(test_insert, NULL);
513 p = strchr(test_insert, ':');
514 if (p)
515 p++;
516
517 for (test = tests; test < tests + count; test++) {
>>> CID 376995: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "p" to "strcmp", which dereferences it. [Note: The source code implementation of the function has been overridden by a builtin model.]
518 if (!strcmp(p, test->name))
519 one = test;
520 }
521 }
522
523 for (upto = 0, test = tests; test < tests + count;
test++, upto++) {

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]