From: Heiko Schocher via U-Boot <u-boot@lists.u-boot-project.org>
To: Junhui Liu <junhui.liu@pigmoral.tech>,
Guodong Xu <guodong@riscstar.com>,
u-boot-spacemit@groups.io, u-boot@lists.u-boot-project.org
Cc: Huan Zhou <pericycle.cc@gmail.com>,
Guodong Xu <guodong.xu@riscstar.com>,
Tom Rini <trini@konsulko.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Lukasz Majewski <lukma@denx.de>, Yixun Lan <dlan@kernel.org>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>
Subject: Re: [PATCH 1/2] i2c: k1: fix wrong bus speed setting
Date: Fri, 14 Aug 2026 11:32:35 +0200 [thread overview]
Message-ID: <4c2c53f7-48db-b65c-e5a1-68200f3f683f@nabladev.com> (raw)
In-Reply-To: <20260814-k1-i2c-fix-v1-1-f2e19cbe0af6@pigmoral.tech>
Hello Junhui Liu,
On 14.08.26 03:46, Junhui Liu wrote:
> The controller bus mode should be selected according to the requested
> I2C bus speed. However, the driver currently passes the functional clock
> rate to k1_i2c_set_bus_speed(), so the selected mode does not reflect
> the requested bus speed.
>
> Fix this by reading the clock-frequency property from the Device Tree,
> defaulting to standard speed, and drop the unused clk_rate field.
>
> Fixes: 271546fb8e54 ("i2c: k1: add I2C driver support")
> Signed-off-by: Junhui Liu <junhui.liu@pigmoral.tech>
> ---
> drivers/i2c/k1_i2c.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Heiko Schocher <hs@nabladev.com>
bye,
Heiko
--
Nabla Software Engineering
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@nabladev.com
Geschäftsführer : Stefano Babic
next prev parent reply other threads:[~2026-08-14 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 1:46 [PATCH 0/2] i2c/clk: spacemit: k1: fix bus configuration and clock handling Junhui Liu
2026-08-14 1:46 ` [PATCH 1/2] i2c: k1: fix wrong bus speed setting Junhui Liu
2026-08-14 9:32 ` Heiko Schocher via U-Boot [this message]
2026-08-14 1:46 ` [PATCH 2/2] i2c: k1: enable all clocks for I2C controllers Junhui Liu
2026-08-14 8:38 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c2c53f7-48db-b65c-e5a1-68200f3f683f@nabladev.com \
--to=u-boot@lists.u-boot-project.org \
--cc=dlan@kernel.org \
--cc=guodong.xu@riscstar.com \
--cc=guodong@riscstar.com \
--cc=hs@nabladev.com \
--cc=junhui.liu@pigmoral.tech \
--cc=lukma@denx.de \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=trini@konsulko.com \
--cc=troy.mitchell@linux.spacemit.com \
--cc=u-boot-spacemit@groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox