From: Yannic Moog <Y.Moog@phytec.de>
To: "festevam@gmail.com" <festevam@gmail.com>,
Teresa Remmet <T.Remmet@phytec.de>
Cc: "upstream@lists.phytec.de" <upstream@lists.phytec.de>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"uboot-imx@nxp.com" <uboot-imx@nxp.com>,
"sbabic@denx.de" <sbabic@denx.de>,
Wadim Egorov <W.Egorov@phytec.de>,
Daniel Schultz <D.Schultz@phytec.de>
Subject: Re: [PATCH v2 0/6] PHYTEC SoM detection for phyCORE-i.MX8MP
Date: Fri, 25 Aug 2023 11:46:56 +0000 [thread overview]
Message-ID: <4c96ce5582528161fee84bf10ae626f081bff07e.camel@phytec.de> (raw)
In-Reply-To: <CAOMZO5AQUPKM7GdLVRM1UZNLw4W2PXQ72L2vtQY7vYr_wmSCMQ@mail.gmail.com>
Hi Fabio
On Thu, 2023-08-24 at 08:52 -0300, Fabio Estevam wrote:
> Hi Yannic,
>
> On Thu, Aug 17, 2023 at 5:57 AM Teresa Remmet <t.remmet@phytec.de>
> wrote:
> >
> > second version of the series to add support for EEPROM SoM
> > detection used
> > by different PHYTEC SoMs. The EEPROM data consist of 32 bytes
> > containing
> > information like PCB revision, RAM size and other SoM specific
> > configuration.
> >
> > For SoMs of the i.MX8M family the data is written to two areas of
> > the
> > used i2c EEPROM.
> >
> > We initally add the detection support for phyCORE-i.MX8MP. Due to
> > layout
> > constraints phyCORE-i.MX8MP SoMs with PCB revision 2 and older can
> > only
> > make use of a lower RAM frequency. This changes with the use of
> > newer PCB
> > revisions. We make use of the factory flashed EEPROM data to detect
> > the
> > PCB revision and select the fitting RAM settings.
> >
> > Changes in v2:
> > - fix wrong RAM Timing values as pointed out by Yannic
> > - removed superfluous goto
> > - removed blank line at EOF
> > - fix string conversion to integer
> > - fix typo s/revsions/revisions
>
> Could you please help review v2?
Yes, I will do it early next week.
>
> Thanks
prev parent reply other threads:[~2023-08-25 11:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 8:57 [PATCH v2 0/6] PHYTEC SoM detection for phyCORE-i.MX8MP Teresa Remmet
2023-08-17 8:57 ` [PATCH v2 1/6] board: phytec: Add common PHYTEC SoM detection Teresa Remmet
2023-08-28 12:32 ` Yannic Moog
2023-10-07 13:00 ` Fabio Estevam
2023-08-17 8:57 ` [PATCH v2 2/6] board: phytec: common: Add imx8m specific EEPROM detection support Teresa Remmet
2023-08-28 12:32 ` Yannic Moog
2023-08-17 8:57 ` [PATCH v2 3/6] board: phytec: phycore-imx8mp: Add EEPROM detection initialisation Teresa Remmet
2023-08-28 12:32 ` Yannic Moog
2023-08-17 8:57 ` [PATCH v2 4/6] board: phytec: phycore_imx8mp: Update 2GB RAM Timings Teresa Remmet
2023-08-28 12:33 ` Yannic Moog
2023-08-17 8:57 ` [PATCH v2 5/6] board: phytec: common: phytec_som_detection: Add helper for PCB revision Teresa Remmet
2023-08-28 12:33 ` Yannic Moog
2023-08-17 8:57 ` [PATCH v2 6/6] board: phytec: phycore_imx8mp: Add 4000MTS RAM timings based on PCB rev Teresa Remmet
2023-08-28 12:33 ` Yannic Moog
2023-08-24 11:52 ` [PATCH v2 0/6] PHYTEC SoM detection for phyCORE-i.MX8MP Fabio Estevam
2023-08-25 11:46 ` Yannic Moog [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c96ce5582528161fee84bf10ae626f081bff07e.camel@phytec.de \
--to=y.moog@phytec.de \
--cc=D.Schultz@phytec.de \
--cc=T.Remmet@phytec.de \
--cc=W.Egorov@phytec.de \
--cc=festevam@gmail.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox