RE: [PATCH v4 1/2] net: brcm: netXtreme driver

[Roman Bacik <roman.bacik@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1946 bytes --]

Hi Marek,

> -----Original Message-----
> From: Marek Behún <marek.behun@nic.cz>
> Sent: Sunday, October 31, 2021 3:56 AM
> To: Roman Bacik <roman.bacik@broadcom.com>
> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Bharat Gooty
> <bharat.gooty@broadcom.com>; Joe Hershberger
> <joe.hershberger@ni.com>; Ramon Fried <rfried.dev@gmail.com>;
> pali@kernel.org
> Subject: Re: [PATCH v4 1/2] net: brcm: netXtreme driver
>
> On Sat, 30 Oct 2021 08:48:05 -0700
> Roman Bacik <roman.bacik@broadcom.com> wrote:
>
> > The mac address can be read from bp only after bnxt_bring_chip is
> > called, which is after read_rom_hwaddr is called. Theoretically we can
> > call bnxt_bring_chip in bind or in read_rom_hwaddr and then one can
> > use this method if desired.
>
> How long does bnxt_bring_chip() take? In milliseconds? If it isn't
> extremely long, I think it could be called from read_rom_hwaddr...
>
> >>     eth_env_set_enetaddr_by_index()
>
> > We can change and use this method.
>
> Pls do, and drop the env deletion.
>
> Marek

We will make requested changes in v5.
Thank you very much for your review,

Roman

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]