From: Fabio Estevam <festevam@denx.de>
To: Tim Harvey <tharvey@gateworks.com>
Cc: "Pali Rohár" <pali@kernel.org>,
"Johannes Schneider" <johannes.schneider@leica-geosystems.com>,
u-boot@lists.denx.de, peng.fan@oss.nxp.com, sbabic@denx.de,
trini@konsulko.com, bsp-development.geo@leica-geosystems.com,
"Peng Fan" <peng.fan@nxp.com>
Subject: Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO
Date: Tue, 25 Oct 2022 19:19:01 -0300 [thread overview]
Message-ID: <4d9e14631817a586e735e7c9f5a86596@denx.de> (raw)
In-Reply-To: <CAJ+vNU0un7Tt=-zn_MzxAsj1euf=e0R5Bt47aFGcWp5S-OQ7NQ@mail.gmail.com>
Hi Tim,
On 25/10/2022 18:37, Tim Harvey wrote:
> Fabio and Pali,
>
> Seems reasonable but this does not resolve the problem. Whatever I
> print in board_init gets cutoff by the print from dm_announce.
Should we check for both TXFULL and TXEMPTY conditions?
--- a/drivers/serial/serial_mxc.c
+++ b/drivers/serial/serial_mxc.c
@@ -311,7 +311,7 @@ static int mxc_serial_putc(struct udevice *dev,
const char ch)
struct mxc_serial_plat *plat = dev_get_plat(dev);
struct mxc_uart *const uart = plat->reg;
- if (readl(&uart->ts) & UTS_TXFULL)
+ if ((readl(&uart->ts) & UTS_TXFULL) || !(readl(&uart->ts) &
UTS_TXEMPTY))
return -EAGAIN;
writel(ch, &uart->txd);
next prev parent reply other threads:[~2022-10-25 22:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 12:15 [PATCH v5 0/2] serial_mxc: fixing reception Johannes Schneider
2022-09-06 12:15 ` [PATCH v5 1/2] serial: mxc: enable the RX pipeline Johannes Schneider
2022-09-18 20:40 ` sbabic
2022-09-06 12:15 ` [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO Johannes Schneider
2022-09-18 20:41 ` sbabic
2022-10-25 19:18 ` Tim Harvey
2022-10-25 20:23 ` Pali Rohár
2022-10-25 20:37 ` Fabio Estevam
2022-10-25 21:37 ` Tim Harvey
2022-10-25 21:48 ` Fabio Estevam
2022-10-25 22:19 ` Fabio Estevam [this message]
2022-10-26 10:10 ` Peng Fan
2022-10-26 10:15 ` Fabio Estevam
2022-10-26 17:45 ` Pali Rohár
2022-10-26 22:22 ` SCHNEIDER Johannes
2022-10-26 22:26 ` Pali Rohár
2022-11-01 20:39 ` Fabio Estevam
2022-11-02 5:16 ` SCHNEIDER Johannes
2022-11-02 12:15 ` Fabio Estevam
2022-11-02 12:38 ` SCHNEIDER Johannes
2022-11-02 14:20 ` Fabio Estevam
2022-11-02 17:24 ` Pali Rohár
2022-11-02 18:37 ` Fabio Estevam
2022-11-03 6:17 ` SCHNEIDER Johannes
2022-11-03 8:35 ` TERTYCHNYI Grygorii
2022-11-03 8:47 ` Pali Rohár
2022-11-03 11:14 ` Fabio Estevam
2022-11-07 21:17 ` Fabio Estevam
2022-11-08 9:37 ` SCHNEIDER Johannes
2022-11-08 11:55 ` Fabio Estevam
2022-10-25 21:41 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d9e14631817a586e735e7c9f5a86596@denx.de \
--to=festevam@denx.de \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=johannes.schneider@leica-geosystems.com \
--cc=pali@kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=sbabic@denx.de \
--cc=tharvey@gateworks.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox