public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3.1 03/13] rockchip: dts: rk3399: Create initial rk3399-u-boot.dtsi
Date: Fri, 26 Apr 2019 15:42:38 +0200	[thread overview]
Message-ID: <4dc7e2d0f4f0da508224e3ffa089f8780395493f.camel@bootlin.com> (raw)
In-Reply-To: <CAMty3ZC5aN-=HKRNy9fYvnQ0wppvBu38WwaCiKWpcnMBTMb7vw@mail.gmail.com>

Hi,

On Fri, 2019-04-26 at 19:07 +0530, Jagan Teki wrote:
> On Fri, Apr 26, 2019 at 7:04 PM Paul Kocialkowski
> <paul.kocialkowski@bootlin.com> wrote:
> > Hi,
> > 
> > On Fri, 2019-04-26 at 18:48 +0530, Jagan Teki wrote:
> > > u-boot,dm-pre-reloc is required for SDMMC booted rk3399 boards and
> > > which is U-Boot specific devicetrees binding.
> > > 
> > > Move it on global rk3399-u-boot.dtsi file and rest of the U-Boot
> > > bindings will move it future based on the requirement.
> > > 
> > > This would help to sync the devicetrees from Linux whenever required
> > > instead of adding specific nodes.
> > > 
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > 
> > Since your patch has changed significantly, you can no longer include a
> > Reviewed-by that was given on a previous iteration.
> > 
> > It looks like we are still missing bits to have rk3399-u-boot.dtsi
> > included, so this patch does not get my Reviewed-by tag.
> 
> It will include rockchip-u-boot.dtsi automatically and I made the
> receptive changes to include other files in this patch [1] and sure I
> will ask Philipp to remove the reviewed-by tag, thanks.

Most importantly (now that I see the new series), you should certainly
have sent that patch as part of your new series because we now have an
inter-dependency between both series.

Could you clean that up and make a proper standalone series that
creates and populates rk3399-u-boot.dtsi?

Cheers,

Paul

> [1] https://patchwork.ozlabs.org/patch/1091543/
-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

  reply	other threads:[~2019-04-26 13:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-26 13:18 [U-Boot] [PATCH v3.1 03/13] rockchip: dts: rk3399: Create initial rk3399-u-boot.dtsi Jagan Teki
2019-04-26 13:34 ` Paul Kocialkowski
2019-04-26 13:37   ` Jagan Teki
2019-04-26 13:42     ` Paul Kocialkowski [this message]
2019-04-26 13:50       ` Jagan Teki
2019-04-26 13:58         ` Paul Kocialkowski
2019-04-26 14:02           ` Jagan Teki
2019-04-26 14:16             ` Paul Kocialkowski
2019-04-26 14:25               ` Jagan Teki
2019-04-26 14:32                 ` Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4dc7e2d0f4f0da508224e3ffa089f8780395493f.camel@bootlin.com \
    --to=paul.kocialkowski@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox