From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FB48C433FE for ; Mon, 23 May 2022 09:17:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0A3DA83F28; Mon, 23 May 2022 11:17:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="BC/iM41Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF63783F28; Mon, 23 May 2022 11:17:25 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on072d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe06::72d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 531AD83F28 for ; Mon, 23 May 2022 11:17:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YqeV6v12o4d01U6werWj5S2gmdSMmd040i2ou9vCOFJmuTgQZ6sENqslRh9Mxq17uriIX1pMnG8E+oEN39UMMOJiLnjsbHzo7ZWcy8C70Xg5gMueSatNHr7brbVjRNhWXekK2rQDqKS639uBdexi4iHhJZ8zPZOEUEKf3xcJIm+bCOkgs/uKDiXS/LrmYFZzVbxmN4MjNRccwG0zIh7yv1dqBC/hHzyBjlGBNo7DyWIt6Bh6XhRtt+LHfLpQ04oF39C6KjaxSmRAMDj98dzfzdKLBdxssgQGjWO4V7g5HwCKfeyUkAYZyBfas7u2esJSeSAYZ3SUXBIhNOjyuaDPSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dmhNUMKPilV42aFhyhsBveWvKx52q5wE0kGiPMZklFs=; b=M/rDiUlQ9R7A8qYhaHIsyUK8H5XOxefBjPakbPuwIT8WLIF6eqgYjznYgD4NmhEd4pXgrKI3g62ZNohfDjrDxLgxb+K0Fm953L1G0hpgT9lGQPdW8G6P8K0wLWlnYFWPir1PlICB2QJccAXdDmER3WwDTJAfq2YPyVCOmCcejvRM8iaw2ckzcMmS0TlA66F0RhivNF39fIX8zWBWxjW7hifro80Duy3QZDNSwnZnATLeTh7eOUAwbLmf69+FsBQTfNBwu2bwA7W9IvCL813B5fsd2TazBX9aLOSEkLWFi0deqZqjl2GAXI/kQUvojWIzYmu2s8a6tMphTseKQf/1DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dmhNUMKPilV42aFhyhsBveWvKx52q5wE0kGiPMZklFs=; b=BC/iM41YfS7Hrc69Z9JZ5sGtexIAVQv4asUbFezwds2LVCt4FjN+UsEwnx0OYI8zucZ2ZcQjWkUMFj32jeRYw+eZH2xWioNL/MQyULJeN2edO6gdEk+ZPIzfKSbxx4sbNPMRgq3ceFhQwLGlTH6CtQW9y1mIm3k6cqJIilU/tDI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=prevas.dk; Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) by DB9PR10MB5550.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:309::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 09:17:19 +0000 Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::7d61:b91a:e773:4e]) by DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::7d61:b91a:e773:4e%6]) with mapi id 15.20.5273.022; Mon, 23 May 2022 09:17:19 +0000 Message-ID: <4e1cbbc0-1008-b68c-e7ff-a7cb8929f74d@prevas.dk> Date: Mon, 23 May 2022 11:17:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Christophe Roullier , Stephen Warren From: Rasmus Villemoes Cc: u-boot , Marek Vasut , Patrick Delaunay Subject: dwc_eth_qos driver for tegra Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0167.eurprd04.prod.outlook.com (2603:10a6:20b:331::22) To DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ff70b5c-bde9-45ab-afbf-08da3c9d0993 X-MS-TrafficTypeDiagnostic: DB9PR10MB5550:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s+vkf8sKbPQ5s1CNUQzacvz7W9HLaeAkaNSraltAk9uq/QPuy8ja6y6RmZqFaslulmA+kzWKazEKh79ScHxHTrVtPGD9A87mOOC0pbutsiyTHm7wyZ2fes7oVxJjuaEjv1txbkPgJ9sha8+tv3oMwxVbvHTvT6vheC3DlV3CUywCJDWqKnf0Gb6dqmqo8zO6wCACLDF7DWHaV51IFMbyaGKLZ55AdewLZWoAwKkiP7UThr5vanf3qqwkXgQTJsP47AT5Ezgv5Nbb/rRznpAvOlpES42AVIswFV8UHXExPwW67FJpNWs0DIU+SyoI1yVRojbsG18gD6/8ZEhMJ2x99LBk01KQcdA/wJy16fW15SVxyh3HIwivXvK5J+Kwo+obeHqrqawkazBsApLfDERJASJIax11pfWpWOKvFIzIEqG9OEq0Ykp4hAE85FeSclm5tSGScIaViRdEzri6yiF12aX9sCmo3SR1gf0UTR9SqqPfcAOZGWtXhIhcA8/1wm067k2ySMArPPa0dObs4FcdTpOC4W9cbklbKmY7mzEbjMxEU24vFMwmk503oMBQZGrPalsGLomkaqxnqLYRh35geiUBdQbLvxh9XE46yEy2VrsPmXUo69actMTSzc2quzvGQQp2gvuG+cUaBtomdUUEk8j7biPO7yo7pJa0fuTL62BSPX2JlwetKtz5cDTinBpfeDtNmVGsmFsjHGWZw1j/6O8LdczKhb/W8mjATjr4uNE3eNaQLGD5KZK4j3C0veJpFOB1lDWkOZ6ZRYFjl8dp4w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(110136005)(26005)(54906003)(6512007)(2906002)(36756003)(31686004)(38350700002)(316002)(6486002)(6506007)(8936002)(4326008)(38100700002)(52116002)(508600001)(44832011)(5660300002)(4744005)(86362001)(31696002)(8676002)(8976002)(66946007)(186003)(66476007)(66556008)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2JtK1ZIekwxb28vZVZyTnd4SjdnWWZSWU9hTTdqOVlYZGo4a1dId1NhZ2JY?= =?utf-8?B?cW80OGlTSkxyc0huY3V5eGlVSzNzWUtiREVKMk9kRlE4MzBMd0tnS1N1V3ky?= =?utf-8?B?OXVGQUc5MllldVNKRmg4WmxFMFNlRndENFR1UGU2TnJDMnRPNGMyeWxra0Rt?= =?utf-8?B?UWlxczBEVXFaK3VWRkd6QWJNdVRjVldScnhsVk9vcmpOelBwRDVrK21QYWUy?= =?utf-8?B?aUJOZ29za0VDYVl3RlBCaXJZQkxQeFZScDNOMEJkN3F1U1VBQ0dBZlNZZmRI?= =?utf-8?B?T1FiWXVEWlNHc3ZIYmRPK2xoVU0zSTVoVFFOdHIreStJT2VtN0N1Y1N2WDRB?= =?utf-8?B?U2ZlYmF1NVBMSjRXQnNja3dQVVcvVElGMTU3TGY0ckNyaFBTdVZ3Qk80ZGhq?= =?utf-8?B?V3pkcjBsVGpWOHNpcUZtK0NuRlg5R3FNdEx1YjhEMUFUdDk4dnNSbWpIUFZF?= =?utf-8?B?a0xQeU93NTZZQ1dSSHVkajAwZVI1YW1WK3huUERoZ2RrWUNLWFVFMlcrS2Rr?= =?utf-8?B?eWJoOTY5NEJvYU50eWE2Y1FVSzNVZnZwMGZWM2FVTTh3WFgvcXhRaVR0UExJ?= =?utf-8?B?YmZSOHQ2NWxLT0hiSU9qOWRMeklJOEI5dmVDbExxMktCdy9tTXlZNm1CVnY2?= =?utf-8?B?cmd2NkVSMjFtRitEdVJDUkNGdTZ4K0Q1WmNTVGhxSis1MGF6Y3NFVlY2K0Qw?= =?utf-8?B?M2g4Q2x4SzJFWVRHWFFZR29vYjRkVzZNeENlSlR1dkZidFljaGxSUXEySVFo?= =?utf-8?B?Y0tEcDlaMXRCeitqZHErK1dHSzJIZEJROHRTZUZ4UU5VQVpwSGhtVTZ3MStS?= =?utf-8?B?cGtqSXdWTWsxcG1hSSsxTUxYTXl6Y2NQNTRUdXh4dXJqQktnSHE4UEdxVThn?= =?utf-8?B?MFp3cVByNHYxY0dKcFE1cU1Vclk4UVNxTFI2cUhiRkdRK1QxUWR4Qm5LY0xK?= =?utf-8?B?c2lVWnlDWElpak1aTndWTi9qZXR6VWdDd3NhRVUwYU50TUl2dkZiVUl3Q1JI?= =?utf-8?B?enJVZVBMTG5MMm9ZMFp4TzVIUVlGRnlJSzk4V0lSV0c3MHJaTC81NWZsbkg3?= =?utf-8?B?TXVIdDg0TFdncVJpZFpsQmRsTTVaMFVWZjNZVU10VkVlWWd4Z2xINU8yNXJ2?= =?utf-8?B?NC9CRDF3cVE5aTZlVWVFekM3aHBuRWh3QWtWcUVYZWFRMDFNSjl4VWlzOWFM?= =?utf-8?B?TTF0UWdscGJYWldYMXc0dStFUFA0M1ppVytFdzV1cXdrY21NQ0FKdTBERXI2?= =?utf-8?B?MC9wbVR2ZUJPSGNUdmtHUWRwUkdFOTJBZi9QLytZdkJNelJaT0NkZEZJV1N2?= =?utf-8?B?bzhrSU56UG9MZ2x1b3orNVpJVjdrWkE4ckQ4V2RjWTdCZ3dBd25QdWlFOWNz?= =?utf-8?B?VXBLbXdweVlzWnh3UG5kK05NbGxJWVg1VzA2OG0yVnk0S3VrWWIyWE40cWNh?= =?utf-8?B?MHlkT3FPTUxBOS9XYmx0Y3RVd2VBTlJIY3FqaGRMNElKYUR6a0ZuT3JDK0xS?= =?utf-8?B?aEdlMXJHR0drZ21xc3lTS1dwc1FiT1FpZEtHN0J3Q0NjdmQ1T2M3bmFMTitX?= =?utf-8?B?U2FQYjYrcGcxY0VQTm82eDdRVDFsSk9xR1owdWk2WmMwNmM5MkprRVQvQmJ5?= =?utf-8?B?MmNzVzV5YXQzVjBqbHFJcTFsS0hJYzJtYWR2MkZoQlUvVGFwMjVNc0xjbW9x?= =?utf-8?B?Sm84SjlvclByOVozSm53cC80d0I3bThvVmgxaTRmUDlnQ25hRTQ2Vi8yaTcz?= =?utf-8?B?MVdSYU1EK2ZiMnJ6VTkydHBFZHRDUHFGTmRBK3pPbkl0dVUyRXRWL0xGNUlU?= =?utf-8?B?aDRtYktFbm1lbHVEekI2REQrT1JXUjNobFlqYjJsNE9LSU5wTWJQbXpxOW1C?= =?utf-8?B?OWhTcEtGb3ZUN2VMMWE3U0YyQ3pSNytpTjRaS0FKK2JFNTVUM3NrNnIzc01t?= =?utf-8?B?RTBrbVM4YzBKR0hKRTdGZ2tKc0xqdTZFQzM2UTU1ZmlHZDFBNmdBKzhmbGRp?= =?utf-8?B?RDhpZ0lvejFvSU9XWGdDOXB5L3NZcU9XR1hzbDR1cHVZVEp2TlJQWEpITkNi?= =?utf-8?B?dGhKSC9NSzJ1eUMvaXdHSkJVYTAyYmgvanAxSHN0b1doWk9zMXdqVDNRdWtN?= =?utf-8?B?K043MnRCRlV5RG0vOEZlcG5lbGczaXRPNnAramRZUkUrQW8zalBEL1Z4ejdm?= =?utf-8?B?N1ZkR1o5NW1mUDJyQWNaQ1hpM1RkblEwZENtY29US1BBaWU2RGNPajhCR1gw?= =?utf-8?B?Z3IvTDV3ajVkWG9hWEZjZTRrUXQwbVl6alZHYXJXY1U4NHJtclNLTnhFKzJT?= =?utf-8?B?NjlFaDRONEtHYm5PdTZCM05Jc0doc1NIalVtSlJsRUtQTW91eHA0T2hMVGEz?= =?utf-8?Q?Vfq9+ZcY7JhVo3dw=3D?= X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: 0ff70b5c-bde9-45ab-afbf-08da3c9d0993 X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 09:17:19.5958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YLq4hYBMmzY3xlTz4WUEBECiiX5pxcqdiwIvkXztnopXTlXPM2lvTmjwIrHQ8zeMm1GhynDNaC5cj9yNJQQd9vF4cYNUu+3M5Y9pipBt0QU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB5550 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi I'm looking at switching the dwc_eth_qos driver over to use dm_eth_phy_connect(). However, I'm a little puzzled by the code for the tegra variant. The comment at the top of the file, as well as tegra186.dtsi, says phy-mode = "rgmii"; But eqos_get_interface_tegra186() returns a hard-coded PHY_INTERFACE_MODE_MII. Now the commit which introduced the ->interface abstraction, ac2d4efb16e (net: dwc_eth_qos: add Ethernet stm32mp1 support), and that eqos_get_interface_tegra186() function, changed - eqos->phy = phy_connect(eqos->mii, 0, dev, 0); to + eqos->phy = phy_connect(eqos->mii, 0, dev, + eqos->config->interface(dev)); and that last hard-coded 0 in the former phy_connect() is indeed equivalent to PHY_INTERFACE_MODE_MII. So which is it? It would be nice if one could just rely on dm_eth_phy_connect() picking up the correct value from device tree, and drop all the code which duplicates parsing of phy-mode from the ethernet driver. Rasmus