From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E552FC77B73 for ; Thu, 20 Apr 2023 12:47:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6A9DC862E9; Thu, 20 Apr 2023 14:47:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="aPaVQXn0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 024BB862DA; Thu, 20 Apr 2023 14:47:26 +0200 (CEST) Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on20606.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaf::606]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 83B8686319 for ; Thu, 20 Apr 2023 14:47:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jEVUBmWWrJKHGu5c0GsIwrpJE49T+/T+vS4p0B3/MD6W7dOGPLFlXfD8g7wu9awHGwR1PRGTGRVIRl+REcVjy54PN5xcZR6je78dYbuMLOK8pzFCrSHOQmNU7OpRYqR5XZiKQBosANHCooGppBkAW+r5pwB0ndQt17XYb7kof3/WBL1Nop/KifhVCOBScgHPUBhVkq/SyDpKTPmmSZ79JrB5+He+T8GICfAbtqqGxO54kfZX7bWh45/1OM0NdskT7yah58ty7WTC7WL6bn+nZUuogWS9YvNZN+VfI5NYNLhClMaImKJDwh8U35UsN/+v4xnzHtDClH7u/36+KhNdRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qs7/tSGfoIBDfkzCGLLPZUQk8UnFnelK66ICyy6Jw5Y=; b=hIgpdpE3rjsw4KR85jR/XH4y1dUT75NWQWO6gBY3cfvHIsXlsfd0acCG/ste8rRCoNWTTn9lni+bH4nwk4CMEJYaRxcZLdb6zGuoci5ux74mfo8qnfSCDYE43fNxPGw1X1rwyDGtffR2EtsKrLo8/sRd2gIdTRQSduOHiM3YJUz6rEws79HnyQaQJnJ2JvWf8amyioY//V76CQALoR2KX9WRML9p246r6+x0YPgkOlLQwMQaUaQTWVKDklwhTl2GAXSZHqzeL+5Mob8221sEBZCTbEcQ8RgAkHWsHJrLPgiH72m7Z7Aj0TQY+oRVzfkC/rjdwYWW0TriKzalqL0WdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qs7/tSGfoIBDfkzCGLLPZUQk8UnFnelK66ICyy6Jw5Y=; b=aPaVQXn0UEN+NZDuNP9AzTz7ZUrjk2PScw3e6w4w9YZ6TNIQb284BTeCyF7CKEtpXH78FAZS1pZRihmP4vjgZT89t7wjW6RV3kHvKrcz3XirdIPt4e69pvr9TzE2/OgYPZf6ijoIsvCfMgS8IaNjnogTMM/50V/0Z9h7qOPp5VI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DBAPR04MB7381.eurprd04.prod.outlook.com (2603:10a6:10:1a2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Thu, 20 Apr 2023 12:47:20 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::b999:f2c6:a8cc:7b4]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::b999:f2c6:a8cc:7b4%5]) with mapi id 15.20.6298.045; Thu, 20 Apr 2023 12:47:20 +0000 Message-ID: <4eb3e3e1-e1fb-26ae-de68-ce9f43a4f41b@oss.nxp.com> Date: Thu, 20 Apr 2023 20:47:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] ARM: imx: Fix parsing of ROM log event IDs on iMX8M To: Fedor Ross , u-boot@lists.denx.de References: <20220414163623.16500-1-fedor.ross@ifm.com> From: Peng Fan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SGXP274CA0013.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::25) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DBAPR04MB7381:EE_ X-MS-Office365-Filtering-Correlation-Id: 2957dfa7-7e93-47d9-3f8a-08db419d6147 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bjiNlZWEdZHfV+7uft0UgdRva9s1XJ36e3wM/uHm4OJUo9/Yor32deydr0Bj9NsVKCnQhx8s4IUDm6Gv34qF1De8uM9+uF587hNsH3dLn7Wn0CSmOowO6lBfTu+JCJQSSNE2appy+HocZVVfs2YNpcs7ELS0mqslkcn6zUsUFPvhvDbPq3oSiuj4c5DEARw19Xt7qP5tqKYS4BZ1CItb98TG4M4LA4/kX6gjNrcJsSDMMECo8QIVXC2ttqIq86UzS4u+n7KhqAxCUutMFi15OMTi00+eN8+A9QWhsCFY1JxU5dIq995la/PxyfNeR+H0eh+4b8HTa9dCNwH8MF+Iy20diIW2l4FMCzJ2aWPdnba17MUg++Iik52shengRq2VD9n+OjhvlzH6C0chw9X1Xd8wkXmyzLLfQux7j4cwseh03gsHUdmY1j76ilY8Goj449XO/c6bg5HXHTIzQSiEo+idsjCxCI3y11iRB80BRrecYX59SjQf969Hj23lle8ZddRGPAuXnf1pa4Tb44xWUSUfX4XVr7seT30SghPwVVoaaLXYzPP45axKj6LfLRHuPz3YWH2ISM+kXBRDjZAP/KTHqw4Ug2eBRmVWcEQAyWxtR7GaTOg7wWw6khQCdXqD2VMho2GvupQ1OwBRrr5ZknuPAlRuR0lVuTmSO3bH5gU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(366004)(396003)(346002)(136003)(451199021)(31686004)(38100700002)(6506007)(6512007)(31696002)(186003)(26005)(86362001)(6486002)(66556008)(66946007)(66476007)(41300700001)(6666004)(478600001)(316002)(83380400001)(53546011)(2906002)(44832011)(8676002)(8936002)(2616005)(5660300002)(32563001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2hLZjJHWU1DM2VRRVEyNWhQSWJ2UVU2NHV6VDlRQ1AwQmFQdE1ia2Vzc1M5?= =?utf-8?B?RTF1ZHNjVVVhTXg4NW5pd2tnYWRXVlkxNFc3eklweHRjUEppbWRibVNvUlZ3?= =?utf-8?B?RE1XTDl0cnNMMWMvZk5JbHBSY2swU215NEtWei9EeEhlZXQycXFXaXVDS3l1?= =?utf-8?B?eC92ckI0ekZJYVNyREVwYVB0R2NvbFhveUZ4MmRvVVRkVWxReWdXQVRwUURM?= =?utf-8?B?MExvRm8zdVZVaUNiUXBFNnFYeGEvYjFJdDVjR2tMSC9mdG9JWHQrMFJJejIz?= =?utf-8?B?S1VobDRGSGxHeFhvWTVHQjAvd3MxTkwxRTdFSGgvaUVXbDBXODF6Qk5IOHgw?= =?utf-8?B?RytjN2dPeHFxN3RDeWRlK1loY2IyeXlOczNDUWtUVG1rVVpQNzB0WDRnWVZz?= =?utf-8?B?ZVZ4bkR2d2ozVFJpdGNXS1NqbEM4TzVNcFQrZFJCL0RSR0pHd1ZsSDY3Ty9O?= =?utf-8?B?NkJTbGE3WjdTNG9hdk9iV3FUWEVMUndqN0hvQ3VuTzRYRENuU2hZeHdWK3RH?= =?utf-8?B?R0Y1TDVCTVc1UjRYRm9PYm84MWFVMkVtUHNsRW41bUlXWCs3TUtwTzlwRWZG?= =?utf-8?B?U3BUNW9mZUkveUVaTjlMUWc0M1h4NkRIVHBrZHVkeE9PYWxvQTFyOFJvbk1L?= =?utf-8?B?c1BoNkpMUllpRlpRc2dmclk1SGJNbGNtbzRrWW1EOFA2MldjV1FIL21Gc0Fo?= =?utf-8?B?MmVRNGpWUWV2NGZEWlRrUC9YazhwNjNGZ1R0SjlGajU5WHNBRkxQcEplcUE1?= =?utf-8?B?UnMvZFozMEh4cVZUT1BmQTlhT3BlaHNvbnJUZ29WY0xGdmtieFl3WU0rYmZl?= =?utf-8?B?U0FqUmxQOXJWaTJkSDBTUkN1MmpMMkZuR2ZicEhDR0E0SlkvbEZjUWViTmV5?= =?utf-8?B?UTdubUs5cmlFbUgrNlMzMHdGR2U5OHl2WEViQkwydkZ0a0c1ZnRpU1ZzT3pu?= =?utf-8?B?MEFEa0Z3SkltSGltTFN2MjhJWVJ1SnkvNDZ3eUQwZTZ1MHV0ZG1pQm4rQUkr?= =?utf-8?B?VkhGdE9xSUtoYkwvNWRHMkdqYkRVTDJIZmlMZG1MbWJpNFFjTE03TzRpVEVG?= =?utf-8?B?SGRIc0NRVWhKSXZUR3dmVFlqa25nQnlycWZuYUE2dEk3ai83bzBDMWtkeWRq?= =?utf-8?B?U2lURE55bmZjRWZZOHF0OUFyZnR3SGJSWHFSd2J2TkpRUm4rSEtnNG5Dd1Fq?= =?utf-8?B?bFlkREE5RCt1OTAyZXo4S2pmemdsSFhEQk9JVHNpVmJ4eDBWY1hvdEJtcHVp?= =?utf-8?B?YndHR1FXcVcyVndLRSs0TXpRb2FDbnVOOEJIMXpmQXA1YnNZZXRHc2hOaG5p?= =?utf-8?B?R3pyT3lBU3ljZ205Y1c4QUtEa1hmTDFqdDZUSmRTcEdqaVhUbncvU1FhR3Bu?= =?utf-8?B?ZkZWUlhFSVBsNTAzN2JHa2RaSTNWWGNUa0hzZFIvYStPd0NqZDlsOERsdkR1?= =?utf-8?B?amI1aXpoYjZCNXh4NjhnQzNJL05YU2xVUkdLSHdZVXFldmtxUmxkSzhOT0ZW?= =?utf-8?B?ZVVINktmR0xuUk5jZ3Jna1lOREZDaUZVYTNCV25GaUI4ZXBBQ0I1YVpPTnBR?= =?utf-8?B?U1VlVm04VG5lVGxRYjl5RCtycm5BN2ROclplSnA2T1hLUHBXd1Y1U0ZZd2x2?= =?utf-8?B?bHVTSWJyKzdmbjBlcmhCWldPL1p6WjcyWncxanZKQlZaR1VPWTduMEkyMUZa?= =?utf-8?B?Znp2RnUwWExsTnphUW4zQXNCYUlvclpzQ1hvYWRGbFo5bk9UdVZUOGtXRDdn?= =?utf-8?B?S2hON3lGb3lWdmxZNXBoQWx3K1pML1IxZTJqMEw3dEJRYy9Ta1JCTjhRQnl3?= =?utf-8?B?OG4vdnZwUFptNVhBbTQ3amxoU3Fwd0pacWZoZW5HZ3ZaSU5ENXgxZm9iRnpR?= =?utf-8?B?MGRWZUxFaC9lUm82RDFXTUgrYWkwUldLUXZSdWV2TU41aUtWam9tbnZpUFF6?= =?utf-8?B?cHVNYVRnYlk3R3hCL212d2EvRWZnQ0poU3RqR25PdmNsRFRyUzJpK0RRSklJ?= =?utf-8?B?cEcxcnhxMDk2WDNnSWxxblRwV1NFby9HU2pYbFFPZHFLZERoa2ljN0ZOb1lt?= =?utf-8?B?NVdHYThQL0lUWXZMb3ZyZjhQUGJ2eHhSS2F3MTdVa2FDMHExYW4yZGJSb29a?= =?utf-8?Q?yKgPBZLx73AbPQPwBOTRZL/aK?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2957dfa7-7e93-47d9-3f8a-08db419d6147 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 12:47:20.6357 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V6Mlq1hzQAXaTPORPk5c4NhoD2r7SHnirdtNJs1gpWAUmZpB41O3uXBlEcwNbkQaTSXMbMWNU1QoHeL1qvfQCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7381 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, Marek pointed me this thread. I admitted I overlooked this patch. Will check internally and back. Regards, Peng. On 4/15/2022 2:00 AM, Fedor Ross wrote: > Hello Peng, > > can you please check the parameter of event 0x82 internally? The AN12853 > doesn't mention a parameter for ID 0x82, but we see something else coming > out of the bootrom of iMX8MN. > > Best regards, > Fedor > > Am Do., 14. Apr. 2022 um 18:37 Uhr schrieb : >> >> From: Fedor Ross >> >> It seems like the ROM log events for the iMX8M are not fully covered by >> AN12853 i.MX ROMs Log Events, Rev. 0, May 2020. On iMX8M the ROM event >> ID 0x82 seems to use parameter0 which stops the parsing because the end >> of list is detected too early. >> >> This patch adds ROM event ID 0x82 and skips the next word if ID 0x82 is >> parsed. >> >> >> Fixes: a5ee05cf71 ("ARM: imx: Pick correct eMMC boot partition from ROM > log") >> >> Signed-off-by: Fedor Ross >> Cc: Fabio Estevam >> Cc: Marek Vasut >> Cc: Peng Fan >> Cc: Stefano Babic >> --- >> arch/arm/mach-imx/imx8m/soc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c >> index 8171631db1..4df57cb150 100644 >> --- a/arch/arm/mach-imx/imx8m/soc.c >> +++ b/arch/arm/mach-imx/imx8m/soc.c >> @@ -677,6 +677,7 @@ int spl_mmc_emmc_boot_partition(struct mmc *mmc) >> /* Log entries with 1 parameter, skip 1 */ >> case 0x80: /* Start to perform the device initialization > */ >> case 0x81: /* The boot device initialization completes */ >> + case 0x82: /* Starts to execute boot device driver > pre-config */ >> case 0x8f: /* The boot device initialization fails */ >> case 0x90: /* Start to read data from boot device */ >> case 0x91: /* Reading data from boot device completes */ >> -- >> 2.20.1 >>