From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tabi Timur-B04825 Date: Fri, 13 Jul 2012 12:10:33 +0000 Subject: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location In-Reply-To: <20120713043026.00DD82000B1@gemini.denx.de> References: <1342129594-7861-1-git-send-email-timur@freescale.com> <9F5356FB-8CA2-44DE-9089-64ABD82CA733@freescale.com> <20120713043026.00DD82000B1@gemini.denx.de> Message-ID: <50001038.50303@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > This is a totally broken design then, when you have a growing data > structure where vital information fields get shifted. In such case, > the CRC should have been at the beginning, so it never changes > location. Or even better, you should not have used a binary data > structure at all (guess why the environment in U-Boot has been > implemented the way it is). York is mistaken. The CRC was always at location 0xFC, but for some reason, when I wrote the code, I put it at 0xCC. Now I'm fixing it, and providing some backwards compatibility to avoid causing problems for people who upgrade U-Boot on existing boards. I don't see how this is controversial in any way. -- Timur Tabi Linux kernel developer at Freescale