From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Fri, 13 Jul 2012 17:22:29 -0500 Subject: [U-Boot] [PATCH] fsl: board EEPROM has the CRC in the wrong location In-Reply-To: <50009EE6.2080804@freescale.com> References: <1342129594-7861-1-git-send-email-timur@freescale.com> <9F5356FB-8CA2-44DE-9089-64ABD82CA733@freescale.com> <20120713043026.00DD82000B1@gemini.denx.de> <50001038.50303@freescale.com> <20120713212501.4C8132000F2@gemini.denx.de> <500096E0.9010406@freescale.com> <500098F6.8050702@freescale.com> <50009EE6.2080804@freescale.com> Message-ID: <50009FA5.4070903@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Scott Wood wrote: > I know the spec wouldn't change, except the version number. But as I > said above, there would be no known v2 implementations with the bug. > You would only check the bad CRC location if you see v1 data, because > there are known buggy v1 implementations. I already have that: if ((e.version == NXID_VERSION) && (crc != be32_to_cpup(crcp))) { NXID_VERSION is equal to 1, so we only do the check for the old CRC if we have a v1 EEPROM. -- Timur Tabi Linux kernel developer at Freescale