* [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code
@ 2012-06-27 12:30 Stathis Voukelatos
2012-06-27 12:36 ` Marek Vasut
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Stathis Voukelatos @ 2012-06-27 12:30 UTC (permalink / raw)
To: u-boot
Fixed some typos in the i.MX28 PMU code that sets up the VDDD
and VDDIO power rails. In addition the VDDD and VDDIO brownout
offset values should be divided by a step size before being
programmed to the corresponding registers.
Signed-off-by: Stathis Voukelatos <stathis.voukelatos@linn.co.uk>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Marek Vasut <marek.vasut@gmail.com>
---
arch/arm/cpu/arm926ejs/mx28/spl_power_init.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c b/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
index 4b09b0c..cc71af8 100644
--- a/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
+++ b/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
@@ -716,7 +716,7 @@ int mx28_get_vddio_power_source_off(void)
tmp = readl(&power_regs->hw_power_vddioctrl);
if (tmp & POWER_VDDIOCTRL_DISABLE_FET) {
if ((tmp & POWER_VDDIOCTRL_LINREG_OFFSET_MASK) ==
- POWER_VDDDCTRL_LINREG_OFFSET_0STEPS) {
+ POWER_VDDIOCTRL_LINREG_OFFSET_0STEPS) {
return 1;
}
}
@@ -724,7 +724,7 @@ int mx28_get_vddio_power_source_off(void)
if (!(readl(&power_regs->hw_power_5vctrl) &
POWER_5VCTRL_ENABLE_DCDC)) {
if ((tmp & POWER_VDDIOCTRL_LINREG_OFFSET_MASK) ==
- POWER_VDDDCTRL_LINREG_OFFSET_0STEPS) {
+ POWER_VDDIOCTRL_LINREG_OFFSET_0STEPS) {
return 1;
}
}
@@ -772,7 +772,7 @@ void mx28_power_set_vddio(uint32_t new_target, uint32_t new_brownout)
uint32_t cur_target, diff, bo_int = 0;
uint32_t powered_by_linreg = 0;
- new_brownout = new_target - new_brownout;
+ new_brownout = (new_target - new_brownout + 25) / 50;
cur_target = readl(&power_regs->hw_power_vddioctrl);
cur_target &= POWER_VDDIOCTRL_TRG_MASK;
@@ -858,8 +858,8 @@ void mx28_power_set_vddio(uint32_t new_target, uint32_t new_brownout)
}
clrsetbits_le32(&power_regs->hw_power_vddioctrl,
- POWER_VDDDCTRL_BO_OFFSET_MASK,
- new_brownout << POWER_VDDDCTRL_BO_OFFSET_OFFSET);
+ POWER_VDDIOCTRL_BO_OFFSET_MASK,
+ new_brownout << POWER_VDDIOCTRL_BO_OFFSET_OFFSET);
}
void mx28_power_set_vddd(uint32_t new_target, uint32_t new_brownout)
@@ -869,7 +869,7 @@ void mx28_power_set_vddd(uint32_t new_target, uint32_t new_brownout)
uint32_t cur_target, diff, bo_int = 0;
uint32_t powered_by_linreg = 0;
- new_brownout = new_target - new_brownout;
+ new_brownout = (new_target - new_brownout + 12) / 25;
cur_target = readl(&power_regs->hw_power_vdddctrl);
cur_target &= POWER_VDDDCTRL_TRG_MASK;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code
2012-06-27 12:30 [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code Stathis Voukelatos
@ 2012-06-27 12:36 ` Marek Vasut
2012-07-08 19:15 ` Marek Vasut
2012-07-19 17:14 ` Marek Vasut
2 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2012-06-27 12:36 UTC (permalink / raw)
To: u-boot
Dear Stathis Voukelatos,
> Fixed some typos in the i.MX28 PMU code that sets up the VDDD
> and VDDIO power rails. In addition the VDDD and VDDIO brownout
> offset values should be divided by a step size before being
> programmed to the corresponding registers.
>
> Signed-off-by: Stathis Voukelatos <stathis.voukelatos@linn.co.uk>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Marek Vasut <marek.vasut@gmail.com>
Will test it ASAP. I should be getting new board by next week, so I'll test-
drive it on that one too.
Thanks for finding those!
> ---
> arch/arm/cpu/arm926ejs/mx28/spl_power_init.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
> b/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c index 4b09b0c..cc71af8
> 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
> @@ -716,7 +716,7 @@ int mx28_get_vddio_power_source_off(void)
> tmp = readl(&power_regs->hw_power_vddioctrl);
> if (tmp & POWER_VDDIOCTRL_DISABLE_FET) {
> if ((tmp & POWER_VDDIOCTRL_LINREG_OFFSET_MASK) ==
> - POWER_VDDDCTRL_LINREG_OFFSET_0STEPS) {
> + POWER_VDDIOCTRL_LINREG_OFFSET_0STEPS) {
> return 1;
> }
> }
> @@ -724,7 +724,7 @@ int mx28_get_vddio_power_source_off(void)
> if (!(readl(&power_regs->hw_power_5vctrl) &
> POWER_5VCTRL_ENABLE_DCDC)) {
> if ((tmp & POWER_VDDIOCTRL_LINREG_OFFSET_MASK) ==
> - POWER_VDDDCTRL_LINREG_OFFSET_0STEPS) {
> + POWER_VDDIOCTRL_LINREG_OFFSET_0STEPS) {
> return 1;
> }
> }
> @@ -772,7 +772,7 @@ void mx28_power_set_vddio(uint32_t new_target, uint32_t
> new_brownout) uint32_t cur_target, diff, bo_int = 0;
> uint32_t powered_by_linreg = 0;
>
> - new_brownout = new_target - new_brownout;
> + new_brownout = (new_target - new_brownout + 25) / 50;
>
> cur_target = readl(&power_regs->hw_power_vddioctrl);
> cur_target &= POWER_VDDIOCTRL_TRG_MASK;
> @@ -858,8 +858,8 @@ void mx28_power_set_vddio(uint32_t new_target, uint32_t
> new_brownout) }
>
> clrsetbits_le32(&power_regs->hw_power_vddioctrl,
> - POWER_VDDDCTRL_BO_OFFSET_MASK,
> - new_brownout << POWER_VDDDCTRL_BO_OFFSET_OFFSET);
> + POWER_VDDIOCTRL_BO_OFFSET_MASK,
> + new_brownout << POWER_VDDIOCTRL_BO_OFFSET_OFFSET);
> }
>
> void mx28_power_set_vddd(uint32_t new_target, uint32_t new_brownout)
> @@ -869,7 +869,7 @@ void mx28_power_set_vddd(uint32_t new_target, uint32_t
> new_brownout) uint32_t cur_target, diff, bo_int = 0;
> uint32_t powered_by_linreg = 0;
>
> - new_brownout = new_target - new_brownout;
> + new_brownout = (new_target - new_brownout + 12) / 25;
>
> cur_target = readl(&power_regs->hw_power_vdddctrl);
> cur_target &= POWER_VDDDCTRL_TRG_MASK;
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code
2012-06-27 12:30 [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code Stathis Voukelatos
2012-06-27 12:36 ` Marek Vasut
@ 2012-07-08 19:15 ` Marek Vasut
2012-07-08 19:43 ` Fabio Estevam
2012-07-19 17:14 ` Marek Vasut
2 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2012-07-08 19:15 UTC (permalink / raw)
To: u-boot
Dear Stathis Voukelatos,
> Fixed some typos in the i.MX28 PMU code that sets up the VDDD
> and VDDIO power rails. In addition the VDDD and VDDIO brownout
> offset values should be divided by a step size before being
> programmed to the corresponding registers.
>
> Signed-off-by: Stathis Voukelatos <stathis.voukelatos@linn.co.uk>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Marek Vasut <marek.vasut@gmail.com>
All right, yet another minus point for my responsiveness :-(
Tested-by: Marek Vasut <marex@denx.de>
Acked-by: Marek Vasut <marex@denx.de>
Fabio, can you give it a quick spin on mx28evk so we can roll this late into
this release maybe ?
> ---
> arch/arm/cpu/arm926ejs/mx28/spl_power_init.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
> b/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c index 4b09b0c..cc71af8
> 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
> @@ -716,7 +716,7 @@ int mx28_get_vddio_power_source_off(void)
> tmp = readl(&power_regs->hw_power_vddioctrl);
> if (tmp & POWER_VDDIOCTRL_DISABLE_FET) {
> if ((tmp & POWER_VDDIOCTRL_LINREG_OFFSET_MASK) ==
> - POWER_VDDDCTRL_LINREG_OFFSET_0STEPS) {
> + POWER_VDDIOCTRL_LINREG_OFFSET_0STEPS) {
> return 1;
> }
> }
> @@ -724,7 +724,7 @@ int mx28_get_vddio_power_source_off(void)
> if (!(readl(&power_regs->hw_power_5vctrl) &
> POWER_5VCTRL_ENABLE_DCDC)) {
> if ((tmp & POWER_VDDIOCTRL_LINREG_OFFSET_MASK) ==
> - POWER_VDDDCTRL_LINREG_OFFSET_0STEPS) {
> + POWER_VDDIOCTRL_LINREG_OFFSET_0STEPS) {
> return 1;
> }
> }
> @@ -772,7 +772,7 @@ void mx28_power_set_vddio(uint32_t new_target, uint32_t
> new_brownout) uint32_t cur_target, diff, bo_int = 0;
> uint32_t powered_by_linreg = 0;
>
> - new_brownout = new_target - new_brownout;
> + new_brownout = (new_target - new_brownout + 25) / 50;
>
> cur_target = readl(&power_regs->hw_power_vddioctrl);
> cur_target &= POWER_VDDIOCTRL_TRG_MASK;
> @@ -858,8 +858,8 @@ void mx28_power_set_vddio(uint32_t new_target, uint32_t
> new_brownout) }
>
> clrsetbits_le32(&power_regs->hw_power_vddioctrl,
> - POWER_VDDDCTRL_BO_OFFSET_MASK,
> - new_brownout << POWER_VDDDCTRL_BO_OFFSET_OFFSET);
> + POWER_VDDIOCTRL_BO_OFFSET_MASK,
> + new_brownout << POWER_VDDIOCTRL_BO_OFFSET_OFFSET);
> }
>
> void mx28_power_set_vddd(uint32_t new_target, uint32_t new_brownout)
> @@ -869,7 +869,7 @@ void mx28_power_set_vddd(uint32_t new_target, uint32_t
> new_brownout) uint32_t cur_target, diff, bo_int = 0;
> uint32_t powered_by_linreg = 0;
>
> - new_brownout = new_target - new_brownout;
> + new_brownout = (new_target - new_brownout + 12) / 25;
>
> cur_target = readl(&power_regs->hw_power_vdddctrl);
> cur_target &= POWER_VDDDCTRL_TRG_MASK;
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code
2012-07-08 19:15 ` Marek Vasut
@ 2012-07-08 19:43 ` Fabio Estevam
0 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2012-07-08 19:43 UTC (permalink / raw)
To: u-boot
Hi Marek,
On Sun, Jul 8, 2012 at 4:15 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Fabio, can you give it a quick spin on mx28evk so we can roll this late into
> this release maybe ?
I don't have access to my mx28evk now and will be out of the office in
the following 2 weeks.
Maybe Otavio could test it on a mx28evk?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code
2012-06-27 12:30 [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code Stathis Voukelatos
2012-06-27 12:36 ` Marek Vasut
2012-07-08 19:15 ` Marek Vasut
@ 2012-07-19 17:14 ` Marek Vasut
2012-07-20 10:05 ` Stefano Babic
2 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2012-07-19 17:14 UTC (permalink / raw)
To: u-boot
Dear Stathis Voukelatos,
> Fixed some typos in the i.MX28 PMU code that sets up the VDDD
> and VDDIO power rails. In addition the VDDD and VDDIO brownout
> offset values should be divided by a step size before being
> programmed to the corresponding registers.
>
> Signed-off-by: Stathis Voukelatos <stathis.voukelatos@linn.co.uk>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Marek Vasut <marek.vasut@gmail.com>
Stefano, I think this should be applied.
THanks!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code
2012-07-19 17:14 ` Marek Vasut
@ 2012-07-20 10:05 ` Stefano Babic
2012-07-20 11:43 ` Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Stefano Babic @ 2012-07-20 10:05 UTC (permalink / raw)
To: u-boot
On 19/07/2012 19:14, Marek Vasut wrote:
> Dear Stathis Voukelatos,
>
>> Fixed some typos in the i.MX28 PMU code that sets up the VDDD
>> and VDDIO power rails. In addition the VDDD and VDDIO brownout
>> offset values should be divided by a step size before being
>> programmed to the corresponding registers.
>>
>> Signed-off-by: Stathis Voukelatos <stathis.voukelatos@linn.co.uk>
>> Cc: Stefano Babic <sbabic@denx.de>
>> Cc: Marek Vasut <marek.vasut@gmail.com>
>
> Stefano, I think this should be applied.
There are checkpatch errors that should be fixed before applying.
Stathis, can you check them and resubmit ? Thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code
2012-07-20 10:05 ` Stefano Babic
@ 2012-07-20 11:43 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2012-07-20 11:43 UTC (permalink / raw)
To: u-boot
Dear Stefano Babic,
> On 19/07/2012 19:14, Marek Vasut wrote:
> > Dear Stathis Voukelatos,
> >
> >> Fixed some typos in the i.MX28 PMU code that sets up the VDDD
> >> and VDDIO power rails. In addition the VDDD and VDDIO brownout
> >> offset values should be divided by a step size before being
> >> programmed to the corresponding registers.
> >>
> >> Signed-off-by: Stathis Voukelatos <stathis.voukelatos@linn.co.uk>
> >> Cc: Stefano Babic <sbabic@denx.de>
> >> Cc: Marek Vasut <marek.vasut@gmail.com>
> >
> > Stefano, I think this should be applied.
>
> There are checkpatch errors that should be fixed before applying.
> Stathis, can you check them and resubmit ? Thanks.
I can eventually resubmit if Stathis grew unhappy about the slow response time
:-(
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-07-20 11:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-27 12:30 [U-Boot] [PATCH] i.MX28: bug fixes in PMU configuration code Stathis Voukelatos
2012-06-27 12:36 ` Marek Vasut
2012-07-08 19:15 ` Marek Vasut
2012-07-08 19:43 ` Fabio Estevam
2012-07-19 17:14 ` Marek Vasut
2012-07-20 10:05 ` Stefano Babic
2012-07-20 11:43 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox