From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Fri, 20 Jul 2012 16:12:49 -0500 Subject: [U-Boot] [PATCH 1/2] powerpc: Stack Pointer must be 16 aligned In-Reply-To: <1342776046-25513-1-git-send-email-Joakim.Tjernlund@transmode.se> References: <1342776046-25513-1-git-send-email-Joakim.Tjernlund@transmode.se> Message-ID: <5009C9D1.70601@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/20/2012 04:20 AM, Joakim Tjernlund wrote: > The PowerPC ABI mandates the SP to be 16 bytes aligned, make is so. > > Signed-off-by: Joakim Tjernlund > --- > arch/powerpc/lib/board.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git arch/powerpc/lib/board.c arch/powerpc/lib/board.c > index d5b75e5..dc7cc40 100644 > --- arch/powerpc/lib/board.c > +++ arch/powerpc/lib/board.c > @@ -521,9 +521,8 @@ void board_init_f(ulong bootflag) > addr_sp -= 16; > addr_sp &= ~0xF; > s = (ulong *) addr_sp; > - *s-- = 0; > - *s-- = 0; > - addr_sp = (ulong) s; > + *s = 0; /* NULL Back Chain */ > + *--s = 0; /* NULL LR */ Same problems as in patch 2/2. -Scott