From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/17] tegra: Add display driver and LCD support for Seaboard
Date: Tue, 24 Jul 2012 13:16:54 -0600 [thread overview]
Message-ID: <500EF4A6.1020308@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ3wRApGj7wpy5YrLvx7wWMf5d0fbiwghEOy0Ny3D3LSOw@mail.gmail.com>
On 07/18/2012 12:51 AM, Simon Glass wrote:
> +Tom, Stephen
>
> On Tue, Jul 17, 2012 at 5:11 PM, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
>> On Sat, Jul 14, 2012 at 10:03:31AM +0200, Simon Glass wrote:
>>> Hi Christian,
>>>
>>> On Thu, Apr 19, 2012 at 2:41 PM, Christian Kroehnert
>>> <christian.kroehnert@avionic-design.de> wrote:
...
>>>> In the display.c source file I implemented a bug fix, because I get garbled
>>>> images on the LCD without this fix.
>>>
>>> I see this code:
>>>
>>> u32 m_value;
>>>
>>> m_value = readl(0x54202e04);
>>> m_value &= ~0x2;
>>> writel(m_value, 0x54202e04);
>>>
>>> What register are you actually writing here? I can't find it in my
>>> manual, but maybe I just haven't seen that address.
>>
>> At the time I did look for that register as well but couldn't find
>> anything. But I believe that we saw the garbled display issue that
>> has been mentioned in another thread. If I remember correctly this
>> particular register write was the fix for it.
>>
>> But I wasn't very much involved at the time, so maybe Christian can
>> clarify. However I was going to test your newest version of the LCD
>> patch series on our hardware and see if the issue is still there.
>
> Does anyone know what this register is for? I am reluctant to add this
> code to the patch without at least a comment.
That address is an alias for DC_WIN_A_BYTE_SWAP_0 (offset 0x701), which
is documented in the TRM. It seems unlikely this was solve the issue at
hand, if I remember it correctly.
prev parent reply other threads:[~2012-07-24 19:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 0:47 [U-Boot] [PATCH 0/17] tegra: Add display driver and LCD support for Seaboard Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 01/17] fdt: Add function to look up a phandle's register address Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 02/17] fdt: Add header guard to fdtdec.h Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 03/17] fdt: Correct GPIO name access in fdtdec Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 04/17] tegra: Add display support to funcmux Simon Glass
2012-01-15 1:36 ` Mike Frysinger
2012-06-13 12:15 ` Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 05/17] tegra: fdt: Add LCD definitions for Tegra Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 06/17] tegra: Add support for PWFM Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 07/17] tegra: Add SOC support for display/lcd Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 08/17] tegra: Add LCD driver Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 09/17] tegra: Add LCD support to Nvidia boards Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 10/17] arm: Add control over cachability of memory regions Simon Glass
2012-02-10 20:38 ` Albert ARIBAUD
2012-03-04 6:20 ` Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 11/17] lcd: Add CONFIG_ALIGN_LCD_TO_SECTION to align lcd for MMU Simon Glass
2012-01-15 1:38 ` Mike Frysinger
2012-06-13 12:23 ` Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 12/17] lcd: Add support for flushing LCD fb from dcache after update Simon Glass
2012-01-15 1:42 ` Mike Frysinger
2012-01-15 1:57 ` Simon Glass
2012-01-15 2:16 ` Mike Frysinger
2012-06-13 12:25 ` Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 13/17] tegra: Align LCD frame buffer to section boundary Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 14/17] tegra: Support control of cache settings for LCD Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 15/17] tegra: fdt: Add LCD definitions for Seaboard Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 16/17] lcd: Add CONSOLE_SCROLL_LINES option to speed console Simon Glass
2012-01-15 0:47 ` [U-Boot] [PATCH 17/17] tegra: Enable display/lcd support on Seaboard Simon Glass
2012-04-19 12:41 ` [U-Boot] [PATCH 0/17] tegra: Add display driver and LCD support for Seaboard Christian Kroehnert
2012-07-14 8:03 ` Simon Glass
2012-07-17 16:11 ` Thierry Reding
2012-07-18 6:51 ` Simon Glass
2012-07-19 12:01 ` Christian Kroehnert
2012-07-24 19:16 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500EF4A6.1020308@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox