* [U-Boot] dwc_ahsata vs ahci
@ 2012-07-28 13:44 Pavel Herrmann
2012-07-29 6:55 ` Stefano Babic
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Herrmann @ 2012-07-28 13:44 UTC (permalink / raw)
To: u-boot
Hi,
While working on the DM project, I found out that there are two
implementations of AHCI drivers - one in block/ahci.c, one in
block/dwc_ahsata.c
what is the difference between them (apart from the obvious, ahci.c exposes
SCSI API, dwc_ahsata exposes SATA API)? are there any problems that would
prevent me from merging them?
thanks
Pavel Herrmann
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] dwc_ahsata vs ahci
2012-07-28 13:44 [U-Boot] dwc_ahsata vs ahci Pavel Herrmann
@ 2012-07-29 6:55 ` Stefano Babic
2012-07-30 8:16 ` Lv Terry-R65388
0 siblings, 1 reply; 5+ messages in thread
From: Stefano Babic @ 2012-07-29 6:55 UTC (permalink / raw)
To: u-boot
On 28/07/2012 15:44, Pavel Herrmann wrote:
> Hi,
>
Hi Pavel,
> While working on the DM project, I found out that there are two
> implementations of AHCI drivers - one in block/ahci.c, one in
> block/dwc_ahsata.c
>
ooopppss !
> what is the difference between them (apart from the obvious, ahci.c exposes
> SCSI API, dwc_ahsata exposes SATA API)? are there any problems that would
> prevent me from merging them?
No, there are not evident reasons !
dwc_asata was inserted to add SATA support for Freescale MX5 family, and
I missed that a similar driver was already in u-boot. dwc_ahsata was
ported from Freescale's u-boot, and linked only for MX5 / MX6 SOCs. I
think it is a very good idea to merge the two drivers (dwc_ahsata seems
an updated version of the original driver), thanks to note this !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] dwc_ahsata vs ahci
2012-07-29 6:55 ` Stefano Babic
@ 2012-07-30 8:16 ` Lv Terry-R65388
2012-07-30 9:20 ` [U-Boot] [U-Boot-DM] " Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Lv Terry-R65388 @ 2012-07-30 8:16 UTC (permalink / raw)
To: u-boot
Hi Pavel,
The ahci.c is a ahci driver using pci interface, while dwc_asata is not.
u-boot don't have a pure ahci driver now, thus we have to reuse some ahci parts from ahci.c in dwc_asata.c.
Thanks~~
Yours
Terry
-----Original Message-----
From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Stefano Babic
Sent: 2012?7?29? 14:56
To: Pavel Herrmann
Cc: u-boot at lists.denx.de; u-boot-dm at lists.denx.de
Subject: Re: [U-Boot] dwc_ahsata vs ahci
On 28/07/2012 15:44, Pavel Herrmann wrote:
> Hi,
>
Hi Pavel,
> While working on the DM project, I found out that there are two
> implementations of AHCI drivers - one in block/ahci.c, one in
> block/dwc_ahsata.c
>
ooopppss !
> what is the difference between them (apart from the obvious, ahci.c
> exposes SCSI API, dwc_ahsata exposes SATA API)? are there any problems
> that would prevent me from merging them?
No, there are not evident reasons !
dwc_asata was inserted to add SATA support for Freescale MX5 family, and I missed that a similar driver was already in u-boot. dwc_ahsata was ported from Freescale's u-boot, and linked only for MX5 / MX6 SOCs. I think it is a very good idea to merge the two drivers (dwc_ahsata seems an updated version of the original driver), thanks to note this !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [U-Boot-DM] dwc_ahsata vs ahci
2012-07-30 8:16 ` Lv Terry-R65388
@ 2012-07-30 9:20 ` Marek Vasut
2012-08-23 15:45 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2012-07-30 9:20 UTC (permalink / raw)
To: u-boot
Dear Lv Terry-R65388,
> Hi Pavel,
>
> The ahci.c is a ahci driver using pci interface, while dwc_asata is not.
>
> u-boot don't have a pure ahci driver now, thus we have to reuse some
ahci
> parts from ahci.c in dwc_asata.c.
Ok, I think we can unify that eventually.
> Thanks~~
>
> Yours
> Terry
>
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On
> Behalf Of Stefano Babic Sent: 2012?7?29? 14:56
> To: Pavel Herrmann
> Cc: u-boot at lists.denx.de; u-boot-dm at lists.denx.de
> Subject: Re: [U-Boot] dwc_ahsata vs ahci
>
> On 28/07/2012 15:44, Pavel Herrmann wrote:
> > Hi,
>
> Hi Pavel,
>
> > While working on the DM project, I found out that there are two
> > implementations of AHCI drivers - one in block/ahci.c, one in
> > block/dwc_ahsata.c
>
> ooopppss !
>
> > what is the difference between them (apart from the obvious, ahci.c
> > exposes SCSI API, dwc_ahsata exposes SATA API)? are there any problems
> > that would prevent me from merging them?
>
> No, there are not evident reasons !
>
> dwc_asata was inserted to add SATA support for Freescale MX5 family, and I
> missed that a similar driver was already in u-boot. dwc_ahsata was ported
> from Freescale's u-boot, and linked only for MX5 / MX6 SOCs. I think it is
> a very good idea to merge the two drivers (dwc_ahsata seems an updated
> version of the original driver), thanks to note this !
>
> Best regards,
> Stefano Babic
>
> --
> =====================================================================
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
> =====================================================================
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>
> _______________________________________________
> U-Boot-DM mailing list
> U-Boot-DM at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot-dm
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [U-Boot-DM] dwc_ahsata vs ahci
2012-07-30 9:20 ` [U-Boot] [U-Boot-DM] " Marek Vasut
@ 2012-08-23 15:45 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2012-08-23 15:45 UTC (permalink / raw)
To: u-boot
Dear Lv Terry-R65388,
> > Hi Pavel,
> >
> > The ahci.c is a ahci driver using pci interface, while dwc_asata is not.
> >
> > u-boot don't have a pure ahci driver now, thus we have to reuse some
>
> ahci
>
> > parts from ahci.c in dwc_asata.c.
>
> Ok, I think we can unify that eventually.
[...]
Bump? Any effort to do so ?
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-23 15:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-28 13:44 [U-Boot] dwc_ahsata vs ahci Pavel Herrmann
2012-07-29 6:55 ` Stefano Babic
2012-07-30 8:16 ` Lv Terry-R65388
2012-07-30 9:20 ` [U-Boot] [U-Boot-DM] " Marek Vasut
2012-08-23 15:45 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox