From: Gerlando Falauto <gerlando.falauto@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7] powerpc/82xx: merge mgcoge.h and mgcoge3ne.h into km82xx.h
Date: Mon, 30 Jul 2012 11:09:14 +0200 [thread overview]
Message-ID: <50164F3A.6050409@keymile.com> (raw)
In-Reply-To: <20120727173051.018DC203A3C@gemini.denx.de>
Dear Wolgfang Denk,
On 07/27/2012 07:30 PM, Wolfgang Denk wrote:
> Dear Gerlando Falauto,
>
> In message<1343402200-32020-4-git-send-email-gerlando.falauto@keymile.com> you wrote:
>> Since mgcoge and mgcoge3ne are the only km82xx boards, there is no need
>> to keep them as separate .h config files.
>> Therefore, make mgcoge3ne.h and mgcoge.h converge into a single km82xx.h
>> file.
>>
>> Signed-off-by: Gerlando Falauto<gerlando.falauto@keymile.com>
>> ---
>> boards.cfg | 4 +-
>> include/configs/km82xx.h | 149 +++++++++++++++++++++++++++++++++++++++++++
>> include/configs/mgcoge.h | 93 ---------------------------
>> include/configs/mgcoge3ne.h | 93 ---------------------------
>> 4 files changed, 151 insertions(+), 188 deletions(-)
>> create mode 100644 include/configs/km82xx.h
>> delete mode 100644 include/configs/mgcoge.h
>> delete mode 100644 include/configs/mgcoge3ne.h
>
> Can you please try creating this patch with git format-patch with
> options "-M" and "-C", please? I think git should do better to
> recognize this rename / merge of two files.
I tried this but to no avail, the resulting patch is still the same.
Same for patch number 4.
I guess git gets confused by the fact that we are merging two files into
one.
What I could do is to split this commit so that, for instance,
first we rename one of the files and then (on a separate commit) we move
the content of one into the other.
In any case, I believe git has no notion of operations like "a file
being embedded into another". I think the best we could do is to put
such changes into a separate commit and mark it explicitly (perhaps
including a sed script in the commit message) so that they can be
automated in case of a rebase.
Question is, is this really worth the effort?
Is there a common practice for such reworks?
Thank you,
Gerlando
next prev parent reply other threads:[~2012-07-30 9:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 15:16 [U-Boot] [PATCH 0/7] km82xx and mgcogeXxx reworking Gerlando Falauto
2012-07-27 15:16 ` [U-Boot] [PATCH 1/7] powerpc/82xx: remove unused define for mgcoge3ne Gerlando Falauto
2012-07-31 20:29 ` Wolfgang Denk
2012-07-27 15:16 ` [U-Boot] [PATCH 2/7] powerpc/82xx: move mgcoge, mgcoge3ne defines to ease subsequent merge Gerlando Falauto
2012-07-31 20:30 ` Wolfgang Denk
2012-08-02 9:14 ` [U-Boot] [PATCH v2 4/7] powerpc/82xx: move km/km82xx-common.h within km82xx.h Gerlando Falauto
2012-07-27 15:16 ` [U-Boot] [PATCH 3/7] powerpc/82xx: merge mgcoge.h and mgcoge3ne.h into km82xx.h Gerlando Falauto
2012-07-27 17:30 ` Wolfgang Denk
2012-07-30 9:09 ` Gerlando Falauto [this message]
2012-07-30 13:00 ` Wolfgang Denk
2012-07-30 14:56 ` Gerlando Falauto
2012-07-30 16:07 ` Wolfgang Denk
2012-07-30 18:21 ` Gerlando Falauto
2012-07-30 18:22 ` [U-Boot] [PATCH v2 " Gerlando Falauto
2012-07-31 20:30 ` [U-Boot] [PATCH " Wolfgang Denk
2012-07-27 15:16 ` [U-Boot] [PATCH 4/7] powerpc/82xx: move km/km82xx-common.h within km82xx.h Gerlando Falauto
2012-07-27 17:31 ` Wolfgang Denk
2012-07-30 18:28 ` Gerlando Falauto
2012-07-30 19:12 ` Wolfgang Denk
2012-08-02 9:10 ` Gerlando Falauto
2012-07-31 20:31 ` Wolfgang Denk
2012-07-27 15:16 ` [U-Boot] [PATCH 5/7] powerpc/82xx: add SDRAM detection for km82xx Gerlando Falauto
2012-07-31 20:31 ` Wolfgang Denk
2012-07-27 15:16 ` [U-Boot] [PATCH 6/7] powerpc/82xx: use SDRAM detection for mgcoge2ne Gerlando Falauto
2012-07-31 20:31 ` Wolfgang Denk
2012-07-27 15:16 ` [U-Boot] [PATCH 7/7] powerpc/82xx: adapt SDRAM settings for mgcoge3ne Gerlando Falauto
2012-07-31 20:31 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50164F3A.6050409@keymile.com \
--to=gerlando.falauto@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox