From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 31 Jul 2012 09:40:24 -0600 Subject: [U-Boot] [PATCH 1/2] cmd_nand: dump: Align data and OOB buffers In-Reply-To: <1343715716-4482-1-git-send-email-thierry.reding@avionic-design.de> References: <1343715716-4482-1-git-send-email-thierry.reding@avionic-design.de> Message-ID: <5017FC68.8090905@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/31/2012 12:21 AM, Thierry Reding wrote: > In order for cache invalidation and flushing to work properly, the data > and OOB buffers must be aligned to full cache lines. > > Signed-off-by: Thierry Reding You probably want to CC the NAND maintainer, Scott Wood (I have here) so he can ack this or apply it. > --- > common/cmd_nand.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/cmd_nand.c b/common/cmd_nand.c > index a91ccf4..4367f5a 100644 > --- a/common/cmd_nand.c > +++ b/common/cmd_nand.c > @@ -48,8 +48,8 @@ static int nand_dump(nand_info_t *nand, ulong off, int only_oob, int repeat) > > last = off; > > - datbuf = malloc(nand->writesize); > - oobbuf = malloc(nand->oobsize); > + datbuf = memalign(ARCH_DMA_MINALIGN, nand->writesize); > + oobbuf = memalign(ARCH_DMA_MINALIGN, nand->oobsize); > if (!datbuf || !oobbuf) { > puts("No memory for page buffer\n"); > return 1;