From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefano babic Date: Tue, 31 Jul 2012 23:20:03 +0200 Subject: [U-Boot] [PATCH] mx53loco: Define CONFIG_BOARD_LATE_INIT In-Reply-To: <20120731205029.8BE98203B34@gemini.denx.de> References: <1343762513-5574-1-git-send-email-fabio.estevam@freescale.com> <501842D4.6060309@denx.de> <20120731205029.8BE98203B34@gemini.denx.de> Message-ID: <50184C03.3050600@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 31/07/2012 22:50, schrieb Wolfgang Denk: > Dear Stefano, > > In message <501842D4.6060309@denx.de> you wrote: >> >>> #ifdef CONFIG_BOARD_LATE_INIT >>> int board_late_init(void) >>> { >>> setenv("stdout", "serial"); >>> >>> return 0; >>> } >>> #endif >>> >>> Signed-off-by: Fabio Estevam >>> --- >> >> Hi Fabio, >> >>> include/configs/mx53loco.h | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h >>> index 0a25c7d..bd23387 100644 >>> --- a/include/configs/mx53loco.h >>> +++ b/include/configs/mx53loco.h >>> @@ -41,6 +41,7 @@ >>> #define CONFIG_SYS_MALLOC_LEN (10 * 1024 * 1024) >>> >>> #define CONFIG_BOARD_EARLY_INIT_F >>> +#define CONFIG_BOARD_LATE_INIT >> >> I see, commit eae08eb2b53ffb87f3342e45ab422d8625659fcd dropped it. >> >> Acked-by: Stefano Babic > > Please see my previous message - I dislike the first part of the > patch, the unconditional "setenv stdout serial". Right - but this is not part of the patch, it is only in the commit message and regards code that is already mainlined. The patch sets only CONFIG_BOARD_LATE_INIT. The part you dislike should be fixed by a separate patch. Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================