From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] gpio: bcm2835: Add GPIO driver
Date: Tue, 31 Jul 2012 22:22:29 -0600 [thread overview]
Message-ID: <5018AF05.9000909@wwwdotorg.org> (raw)
In-Reply-To: <501894F2.10506@gmail.com>
On 07/31/2012 08:31 PM, Vikram Narayanan wrote:
> On 7/31/2012 11:18 PM, Vikram Narayanan wrote:
>> Driver for BCM2835 SoC. This gives the basic functionality of
>> setting/clearing the output.
>> diff --git a/arch/arm/include/asm/arch-bcm2835/gpio.h
>> +#define BCM2835_GPIO_COUNT 53
>
> GPIO count should be 54 to make the gpio_is_valid work correctly when
> the gpio is 53.
> Will fix in v4.
Oh dear. I posted an updated version of your patches which fix a bunch
of errors. I guess I'll wait and see if there are any other comments on
other patches in that series, and re-post that series, or just that
patch, with that fixed later.
P.S. There's no need to quote the entire patch just to comment on one line.
next prev parent reply other threads:[~2012-08-01 4:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 17:48 [U-Boot] [PATCH v3 0/2] Add GPIO driver for BCM2835 SoC Vikram Narayanan
2012-07-31 17:48 ` [U-Boot] [PATCH v3 1/2] gpio: bcm2835: Add GPIO driver Vikram Narayanan
2012-08-01 2:31 ` Vikram Narayanan
2012-08-01 4:22 ` Stephen Warren [this message]
2012-07-31 17:50 ` [U-Boot] [PATCH v3 2/2] rbpi: Add BCM2835 GPIO driver for raspberry pi Vikram Narayanan
2012-08-01 4:15 ` [U-Boot] [PATCH v3 0/2] Add GPIO driver for BCM2835 SoC Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5018AF05.9000909@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox