From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Tue, 31 Jul 2012 22:22:29 -0600
Subject: [U-Boot] [PATCH v3 1/2] gpio: bcm2835: Add GPIO driver
In-Reply-To: <501894F2.10506@gmail.com>
References: <50181A51.8040600@gmail.com> <50181A8A.9090604@gmail.com>
	<501894F2.10506@gmail.com>
Message-ID: <5018AF05.9000909@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 07/31/2012 08:31 PM, Vikram Narayanan wrote:
> On 7/31/2012 11:18 PM, Vikram Narayanan wrote:
>> Driver for BCM2835 SoC. This gives the basic functionality of
>> setting/clearing the output.

>> diff --git a/arch/arm/include/asm/arch-bcm2835/gpio.h

>> +#define BCM2835_GPIO_COUNT    53
> 
> GPIO count should be 54 to make the gpio_is_valid work correctly when
> the gpio is 53.
> Will fix in v4.

Oh dear. I posted an updated version of your patches which fix a bunch
of errors. I guess I'll wait and see if there are any other comments on
other patches in that series, and re-post that series, or just that
patch, with that fixed later.

P.S. There's no need to quote the entire patch just to comment on one line.