From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 07 Aug 2012 14:21:45 -0600 Subject: [U-Boot] [PATCH] tegra20: usb: rework set_host_mode In-Reply-To: <1344363555-32755-1-git-send-email-dev@lynxeye.de> References: <1344363555-32755-1-git-send-email-dev@lynxeye.de> Message-ID: <502178D9.2080708@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/07/2012 12:19 PM, Lucas Stach wrote: > This allows for two things: > - VBus GPIO may be used on other ports than the OTG one > - VBus GPIO may be low active if specified by DT Hmmm. Why would the board have control over whether VBUS is asserted if the port isn't intended to operate in OTG mode? Perhaps power-saving? In that case, I wonder if representing this as a regulator rather than as a VBUS GPIO would make more sense? But irrespective of those questions, I'm inclined to think the patch is probably OK.