From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] rtc: imxdi: Initial support
Date: Wed, 08 Aug 2012 16:29:55 +0200 [thread overview]
Message-ID: <502277E3.1010408@denx.de> (raw)
In-Reply-To: <899997662.2137106.1344427048856.JavaMail.root@advansee.com>
On 08/08/2012 13:57, Beno?t Th?baudeau wrote:
> Add support for Freescale's i.MX DryIce RTC, present on i.MX25.
>
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
Hi Beno?t,
checkpatch reports an error when I run your patch. Can you fix it ?
ERROR: code indent should use tabs where possible
#275: FILE: drivers/rtc/imxdi.c:229:
+^I tmp->tm_hour, tmp->tm_min, tmp->tm_sec);$
Apart of that, here my:
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2012-08-08 14:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1227195557.336910.1342794274777.JavaMail.root@advansee.com>
2012-07-20 14:24 ` [U-Boot] [PATCH] rtc: imxdi: Initial support Benoît Thébaudeau
2012-08-03 23:06 ` Benoît Thébaudeau
2012-08-05 7:13 ` Stefano Babic
2012-08-05 14:14 ` Benoît Thébaudeau
2012-08-08 11:57 ` [U-Boot] [PATCH v2] " Benoît Thébaudeau
2012-08-08 14:29 ` Stefano Babic [this message]
2012-08-08 14:52 ` [U-Boot] [PATCH v3] " Benoît Thébaudeau
2012-08-09 13:58 ` Stefano Babic
2012-08-08 14:57 ` [U-Boot] [PATCH v2] " Benoît Thébaudeau
2012-08-08 15:24 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502277E3.1010408@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox