From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sat, 11 Aug 2012 12:43:21 +0200 Subject: [U-Boot] [PATCH] fsl_esdhc: Add no-snoop config for default init In-Reply-To: <1609724147.2283761.1344633186646.JavaMail.root@advansee.com> References: <1609724147.2283761.1344633186646.JavaMail.root@advansee.com> Message-ID: <50263749.1040101@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/08/2012 23:13, Beno?t Th?baudeau wrote: > cfg->no_snoop was available only through custom fsl_esdhc_mmc init functions. > Add a config options to make it available also through the default init. > Hi Beno?t, > Signed-off-by: Beno?t Th?baudeau > Cc: Andy Fleming > Cc: Stefano Babic > Cc: Kim Phillips > --- > .../drivers/mmc/fsl_esdhc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git u-boot-4d3c95f.orig/drivers/mmc/fsl_esdhc.c u-boot-4d3c95f/drivers/mmc/fsl_esdhc.c > index b6c969d..21154e5 100644 > --- u-boot-4d3c95f.orig/drivers/mmc/fsl_esdhc.c > +++ u-boot-4d3c95f/drivers/mmc/fsl_esdhc.c > @@ -597,6 +597,9 @@ int fsl_esdhc_mmc_init(bd_t *bis) > cfg = malloc(sizeof(struct fsl_esdhc_cfg)); > memset(cfg, 0, sizeof(struct fsl_esdhc_cfg)); > cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR; > +#ifdef CONFIG_SYS_FSL_ESDHC_NO_SNOOP > + cfg->no_snoop = 1; > +#endif > return fsl_esdhc_initialize(bis, cfg); > } > Using a structure to setup the controller avoids to add further CONFIG_ switch. I do not find the needs to have both. Why do you need ? Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================